r96345 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96344‎ | r96345 | r96346 >
Date:15:45, 6 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r95458

Add a couple of bits of documentation

Removed an unused global

No need to 1.18 this
Modified paths:
  • /trunk/phase3/maintenance/refreshImageMetadata.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/refreshImageMetadata.php
@@ -156,6 +156,10 @@
157157 }
158158 }
159159
 160+ /**
 161+ * @param $dbw DatabaseBase
 162+ * @return array
 163+ */
160164 function getConditions( $dbw ) {
161165 $conds = array();
162166
@@ -179,8 +183,12 @@
180184 return $conds;
181185 }
182186
 187+ /**
 188+ * @param $force bool
 189+ * @param $brokenOnly bool
 190+ */
183191 function setupParameters( $force, $brokenOnly ) {
184 - global $wgUpdateCompatibleMetadata, $wgReadOnly;
 192+ global $wgUpdateCompatibleMetadata;
185193
186194 if ( $brokenOnly ) {
187195 $wgUpdateCompatibleMetadata = false;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95458New maintenance script for refreshing image metadata (refreshImageMetadata.php)...bawolff05:33, 25 August 2011

Status & tagging log