r96331 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96330‎ | r96331 | r96332 >
Date:13:32, 6 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r96327

Don't need regexed paths if we're doing it as an SQL query (yay for the prior path fragmentation work!)

Also fix message replacement $1 in 'code-stats-fixme-path'

bug 29292 is all done now
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/ui/CodeRepoStatsView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRepoStatsView.php
@@ -52,7 +52,7 @@
5353 $wgOut->wrapWikiMsg( "<h3 id=\"stats-fixme-path\">$1</h3>", 'code-stats-fixme-breakdown-path' );
5454
5555 foreach ( $stats->fixmesPerPath as $path => $fixmes ) {
56 - $wgOut->wrapWikiMsg( "<h4 id=\"stats-fixme-path\">$1</h4>", 'code-stats-fixme-path', $path );
 56+ $wgOut->wrapWikiMsg( "<h4 id=\"stats-fixme-path\">$1</h4>", array( 'code-stats-fixme-path', $path ) );
5757 $this->writeAuthorTable( 'fixme', $fixmes, array( 'path' => $path ) );
5858 }
5959 }
Index: trunk/extensions/CodeReview/CodeReview.php
@@ -243,7 +243,7 @@
244244 /**
245245 * Key is repository name. Value is an array of key value pairs of the paths to get fixme list for
246246 *
247 - * $wgCodeReviewFixmePerPath = array( 'RepoName' => array( '%^/path/to/use%', '%^/another/path/to/use%' ) )
 247+ * $wgCodeReviewFixmePerPath = array( 'RepoName' => array( '/path/to/use', '/another/path/to/use' ) )
248248 */
249249 $wgCodeReviewFixmePerPath = array();
250250

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96327* (bug 29292) Wall of shame per path...reedy13:16, 6 September 2011

Status & tagging log