r96265 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96264‎ | r96265 | r96266 >
Date:00:56, 5 September 2011
Author:robin
Status:ok
Tags:
Comment:
(bug 30679) Some installer fields should always be LTR
Patch by Amir E. Aharoni (some whitespace fixes)
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlInstaller.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -78,6 +78,7 @@
7979 * Ahmad Sherif
8080 * Alejandro Mery
8181 * Amalthea
 82+* Amir E. Aharoni
8283 * Antonio Ospite
8384 * Azliq7
8485 * Beau
Index: trunk/phase3/includes/installer/DatabaseInstaller.php
@@ -462,8 +462,8 @@
463463 return
464464 Html::openElement( 'fieldset' ) .
465465 Html::element( 'legend', array(), wfMsg( 'config-db-install-account' ) ) .
466 - $this->getTextBox( '_InstallUser', 'config-db-username', array(), $this->parent->getHelpBox( 'config-db-install-username' ) ) .
467 - $this->getPasswordBox( '_InstallPassword', 'config-db-password', array(), $this->parent->getHelpBox( 'config-db-install-password' ) ) .
 466+ $this->getTextBox( '_InstallUser', 'config-db-username', array( 'dir' => 'ltr' ), $this->parent->getHelpBox( 'config-db-install-username' ) ) .
 467+ $this->getPasswordBox( '_InstallPassword', 'config-db-password', array( 'dir' => 'ltr' ), $this->parent->getHelpBox( 'config-db-install-password' ) ) .
468468 Html::closeElement( 'fieldset' );
469469 }
470470
Index: trunk/phase3/includes/installer/MysqlInstaller.php
@@ -75,8 +75,8 @@
7676 $this->getTextBox( 'wgDBserver', 'config-db-host', array(), $this->parent->getHelpBox( 'config-db-host-help' ) ) .
7777 Html::openElement( 'fieldset' ) .
7878 Html::element( 'legend', array(), wfMsg( 'config-db-wiki-settings' ) ) .
79 - $this->getTextBox( 'wgDBname', 'config-db-name', array(), $this->parent->getHelpBox( 'config-db-name-help' ) ) .
80 - $this->getTextBox( 'wgDBprefix', 'config-db-prefix', array(), $this->parent->getHelpBox( 'config-db-prefix-help' ) ) .
 79+ $this->getTextBox( 'wgDBname', 'config-db-name', array( 'dir' => 'ltr' ), $this->parent->getHelpBox( 'config-db-name-help' ) ) .
 80+ $this->getTextBox( 'wgDBprefix', 'config-db-prefix', array( 'dir' => 'ltr' ), $this->parent->getHelpBox( 'config-db-prefix-help' ) ) .
8181 Html::closeElement( 'fieldset' ) .
8282 $this->getInstallUserBox();
8383 }
Index: trunk/phase3/includes/installer/WebInstallerPage.php
@@ -894,12 +894,14 @@
895895 $this->parent->getTextBox( array(
896896 'var' => 'wgDeletedDirectory',
897897 'label' => 'config-upload-deleted',
 898+ 'attribs' => array( 'dir' => 'ltr' ),
898899 'help' => $this->parent->getHelpBox( 'config-upload-deleted-help' )
899900 ) ) .
900901 '</div>' .
901902 $this->parent->getTextBox( array(
902903 'var' => 'wgLogo',
903904 'label' => 'config-logo',
 905+ 'attribs' => array( 'dir' => 'ltr' ),
904906 'help' => $this->parent->getHelpBox( 'config-logo-help' )
905907 ) )
906908 );

Status & tagging log