r96247 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96246‎ | r96247 | r96248 >
Date:18:44, 4 September 2011
Author:maxsem
Status:ok
Tags:
Comment:
Grammar
Modified paths:
  • /trunk/extensions/wikihiero/wikihiero.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/wikihiero/wikihiero.body.php
@@ -86,7 +86,7 @@
8787 * Render hieroglyph text
8888 *
8989 * @param $text string: text to convert
90 - * @param $mode string: convertion mode [DEFAULT|TEXT|HTML|STYLE|IMAGE] (def=HTML)
 90+ * @param $mode string: conversion mode [DEFAULT|TEXT|HTML|STYLE|IMAGE] (def=HTML)
9191 * @param $scale string: global scale in percentage (def=100%)
9292 * @param $line string: use line [true|false] (def=false)
9393 * @return string: converted code
@@ -170,8 +170,8 @@
171171 /**
172172 * Resize a glyph
173173 *
174 - * @param $item string: glyph's code
175 - * @param $is_cartouche bool: true if glyph inside a cartouche
 174+ * @param $item string: glyph code
 175+ * @param $is_cartouche bool: true if glyph is inside a cartouche
176176 * @param $total int: total size of a group for multi-glyph block
177177 * @return size
178178 */
@@ -368,10 +368,10 @@
369369 $contentHtml .= WH_TD_S . self::renderGlyph( $code[0], $option ) . WH_TD_E;
370370 }
371371
372 - // block contain more than 1 glyph
 372+ // block contains more than 1 glyph
373373 } else {
374374
375 - // convert all code into '&' to test prefabs glyph
 375+ // convert all codes into '&' to test prefabs glyph
376376 $temp = "";
377377 foreach ( $code as $t ) {
378378 if ( preg_match( "/[*:!()]/", $t[0] ) ) {
@@ -381,13 +381,13 @@
382382 }
383383 }
384384
385 - // test is block is into tje prefabs list
 385+ // test if block exists in the prefabs list
386386 if ( in_array( $temp, self::$prefabs ) ) {
387387 $option = "height='" . $this->resizeGlyph( $temp, $is_cartouche ) . "'";
388388
389389 $contentHtml .= WH_TD_S . self::renderGlyph( $temp, $option ) . WH_TD_E;
390390
391 - // block must be manualy computed
 391+ // block must be manually computed
392392 } else {
393393 // get block total height
394394 $line_max = 0;

Status & tagging log