r96168 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96167‎ | r96168 | r96169 >
Date:01:42, 3 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
Whitespacing in HtmlTest.php
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/HtmlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/HtmlTest.php
@@ -26,15 +26,15 @@
2727
2828 ### EMPTY ########
2929 $this->AssertEmpty(
30 - Html::expandAttributes( array( 'foo'=>null) ),
 30+ Html::expandAttributes( array( 'foo' => null ) ),
3131 'skip keys with null value'
3232 );
3333 $this->AssertEmpty(
34 - Html::expandAttributes( array( 'foo'=>false) ),
 34+ Html::expandAttributes( array( 'foo' => false ) ),
3535 'skip keys with false value'
3636 );
3737 $this->AssertNotEmpty(
38 - Html::expandAttributes( array( 'foo'=>'') ),
 38+ Html::expandAttributes( array( 'foo' => '' ) ),
3939 'keep keys with an empty string'
4040 );
4141 }
@@ -43,18 +43,18 @@
4444 global $wgHtml5;
4545 $this->AssertEquals(
4646 '',
47 - Html::expandAttributes( array( 'selected'=>false) ),
 47+ Html::expandAttributes( array( 'selected' => false ) ),
4848 'Boolean attributes do not generates output when value is false'
4949 );
5050 $this->AssertEquals(
5151 '',
52 - Html::expandAttributes( array( 'selected'=>null) ),
 52+ Html::expandAttributes( array( 'selected' => null ) ),
5353 'Boolean attributes do not generates output when value is null'
5454 );
5555
5656 $this->AssertEquals(
5757 $wgHtml5 ? ' selected=""' : ' selected="selected"',
58 - Html::expandAttributes( array( 'selected'=>true ) ),
 58+ Html::expandAttributes( array( 'selected' => true ) ),
5959 'Boolean attributes skip value output'
6060 );
6161 $this->AssertEquals(
@@ -72,22 +72,22 @@
7373 ### NOT EMPTY ####
7474 $this->AssertEquals(
7575 ' empty_string=""',
76 - Html::expandAttributes( array( 'empty_string'=>'') ),
 76+ Html::expandAttributes( array( 'empty_string' => '' ) ),
7777 'Value with an empty string'
7878 );
7979 $this->AssertEquals(
8080 ' key="value"',
81 - Html::expandAttributes( array( 'key'=>'value') ),
 81+ Html::expandAttributes( array( 'key' => 'value' ) ),
8282 'Value is a string'
8383 );
8484 $this->AssertEquals(
8585 ' one="1"',
86 - Html::expandAttributes( array( 'one'=>1) ),
 86+ Html::expandAttributes( array( 'one' => 1 ) ),
8787 'Value is a numeric one'
8888 );
8989 $this->AssertEquals(
9090 ' zero="0"',
91 - Html::expandAttributes( array( 'zero'=>0) ),
 91+ Html::expandAttributes( array( 'zero' => 0 ) ),
9292 'Value is a numeric zero'
9393 );
9494 }

Status & tagging log