r96149 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96148‎ | r96149 | r96150 >
Date:21:02, 2 September 2011
Author:yaron
Status:deferred
Tags:
Comment:
Fix for r96144 - a (hopefully) correct check this time
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_FormEdit.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_FormEdit.php
@@ -308,10 +308,10 @@
309309 // Try to save the page!
310310 $resultDetails = array();
311311 $saveResult = $editor->internalAttemptSave( $resultDetails );
312 - if ( method_exists( $saveResult, 'value' ) ) {
 312+ // Return value was made an object in MW 1.19
 313+ if ( is_object( $saveResult ) ) {
313314 $saveResultCode = $saveResult->value;
314315 } else {
315 - // Compatibility with MW < 1.19
316316 $saveResultCode = $saveResult;
317317 }
318318

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96144Follow-up to r95674 - restored compatibility to versions of MediaWiki from be...yaron19:35, 2 September 2011