r96137 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96136‎ | r96137 | r96138 >
Date:18:13, 2 September 2011
Author:preilly
Status:ok
Tags:
Comment:
remove calls to htmlspecialchars the parser deals with what html is allowed and what is not itself and it might mess with the edit token as well
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
——@@ -333,9 +333,9 @@
334334
335335 if ( $mobileAction == 'leave_feedback_post' ) {
336336
337 - $subject = htmlspecialchars( $wgRequest->getText( 'subject', '' ) );
338 - $message = htmlspecialchars( $wgRequest->getText( 'message', '' ) );
339 - $token = htmlspecialchars( $wgRequest->getText( 'edittoken', '' ) );
 337+ $subject = $wgRequest->getText( 'subject', '' );
 338+ $message = $wgRequest->getText( 'message', '' );
 339+ $token = $wgRequest->getText( 'edittoken', '' );
340340
341341 $title = Title::newFromText( 'MobileFrontend Extension Feedback' );
342342

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96134add edit token and user can edit checks and make sure user is not blockedpreilly18:00, 2 September 2011

Status & tagging log