r96008 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96007‎ | r96008 | r96009 >
Date:16:15, 1 September 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Move deps to resource loader
Modified paths:
  • /trunk/extensions/Translate/Translate.php (modified) (history)
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/Translate.php
@@ -144,6 +144,11 @@
145145 'scripts' => 'js/quickedit.js',
146146 'styles' => 'js/ext.translate.quickedit.css',
147147 'messages' => array( 'translate-js-nonext', 'translate-js-save-failed' ),
 148+ 'dependencies' => array(
 149+ 'jquery.form',
 150+ 'jquery.ui.dialog',
 151+ 'jquery.autoresize',
 152+ ),
148153 ) + $resourcePaths;
149154
150155 $wgResourceModules['ext.translate.messagetable'] = array(
Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -1197,9 +1197,6 @@
11981198
11991199 public static function addModules( OutputPage $out ) {
12001200 TranslateUtils::addModules( $out, array(
1201 - 'jquery.form',
1202 - 'jquery.ui.dialog',
1203 - 'jquery.autoresize',
12041201 'ext.translate.quickedit',
12051202 ) );
12061203

Status & tagging log