r95995 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95994‎ | r95995 | r95996 >
Date:15:09, 1 September 2011
Author:siebrand
Status:deferred
Tags:
Comment:
i18n fixes.
Modified paths:
  • /trunk/extensions/Postcomment/Postcomment.i18n.php (modified) (history)
  • /trunk/extensions/Postcomment/Postcomment.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Postcomment/Postcomment.i18n.php
@@ -16,8 +16,8 @@
1717 'postcomment_addcommentdiscussionpage' => 'Add your comment on this discussion page',
1818 'postcomment_leavemessagefor' => 'Leave a message for $1',
1919 'postcomment_post' => 'Post',
20 - 'postcomment_on' => 'On',
21 - 'postcomment_said' => 'said',
 20+ 'postcomment_on' => 'On $1',
 21+ 'postcomment-userwrote' => '[[User:$1|$2]] wrote:',
2222 'postcomment_invalidrequest' => 'Invalid request.',
2323 'postcomment_replyto' => 'Reply to $1',
2424 'postcomment_nopostingtoadd' => 'No posting to add.',
@@ -34,8 +34,11 @@
3535 'postcomment_addcommentdiscussionpage' => 'Message displayed before comment form. For example see http://www.wikihow.com/Discussion:Main-Page',
3636 'postcomment_leavemessagefor' => 'Message displayed before comment form in user talks.',
3737 'postcomment_post' => 'Name of button. For example see http://www.wikihow.com/Discussion:Main-Page',
38 - 'postcomment_on' => '"On" as in "On <date>". For example see http://www.wikihow.com/Discussion:Main-Page',
39 - 'postcomment_said' => '<Username> said. For example see http://www.wikihow.com/Discussion:Main-Page',
 38+ 'postcomment_on' => 'For example see http://www.wikihow.com/Discussion:Main-Page. Parameters:
 39+* $1 is a timestamp.',
 40+ 'postcomment-usersaid' => 'This message supports GENDER. Parameters:
 41+* $1 is a user name
 42+* $2 is a user real name.',
4043 'postcomment_replyto' => '$1 is the user that has posted previous comment. For example see http://www.wikihow.com/Discussion:Main-Page',
4144 );
4245
Index: trunk/extensions/Postcomment/Postcomment.php
@@ -85,21 +85,17 @@
8686 }
8787 $dateStr = $wgLang->timeanddate( wfTimestampNow() );
8888
89 - //echo "$dateStr<br />";
90 -
9189 $formattedComment = "
9290 <div id=\"discussion_entry\"><table width=\"100%\">
93 - <tr><td width=\"50%\" valign=\"top\" class=\"discussion_entry_user\">
94 - [[User:$user|$real_name]] " . wfMsg( 'postcomment_said' ) . ":
95 -</td><td align=\"right\" width=\"50%\" class=\"discussion_entry_date\">" . wfMsg( 'postcomment_on' ) . " $dateStr<br />
 91+ <tr><td width=\"50%\" valign=\"top\" class=\"discussion_entry_user\">" .
 92+ wfMsgExt( 'postcomment-userwrote', array( 'parsemag' ), $user, $real_name ) . "
 93+</td><td align=\"right\" width=\"50%\" class=\"discussion_entry_date\">" . wfMsg( 'postcomment_on', $dateStr ) . "<br />
9694 </td></tr><tr>
9795 <td colspan=2 class=\"discussion_entry_comment\">
9896 $comment</td></tr>
9997 <tr><td colspan=\"2\" class=\"discussion_entry_date\" padding=5>[[User_talk:$user#post|" . wfMsg('postcomment_replyto', $real_name) . "]]</td></tr>
10098 </table></div>
101 -
10299 ";
103 - //echo "$formattedComment";
104100
105101 $text = '';
106102
@@ -110,9 +106,6 @@
111107
112108 $text .= "\n\n$formattedComment\n\n";
113109
114 - //echo "updating with text:<br /> $text";
115 - //exit;
116 -
117110 $tmp = "";
118111 if ( $wgFilterCallback && $wgFilterCallback( $t, $text, $tmp) ) {
119112 # Error messages or other handling should be performed by the filter function

Status & tagging log