r95955 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95954‎ | r95955 | r95956 >
Date:10:05, 1 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
Follows-up r95954: Fix case &ganames& and &ganames=&. Falsey is not enough, empty string or empty array should be used as 'has filter, no titles'
Modified paths:
  • /branches/RL2/extensions/Gadgets/api/ApiQueryGadgets.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/api/ApiQueryGadgets.php
@@ -53,7 +53,7 @@
5454 $repo = new LocalGadgetRepo( array() );
5555 $result = array();
5656
57 - if ( $this->neededNames ) {
 57+ if ( $this->neededNames !== false ) {
5858 // Get all requested gadgets by name
5959 $names = $this->neededNames;
6060 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95954RL2: Hopefully fix bug Timo reported in list=gadgets: names parameter brokencatrope09:56, 1 September 2011

Status & tagging log