r95925 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95924‎ | r95925 | r95926 >
Date:01:10, 1 September 2011
Author:laner
Status:deferred
Tags:ldap 
Comment:
Also pass the userdn, in a way that can be modified, so that the hook can more easily change it
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -764,7 +764,7 @@
765765 $writeloc = '';
766766 }
767767 # Let other extensions modify the user object before creation
768 - wfRunHooks( 'LDAPSetCreationValues', array( $this, $username, &$values, $writeloc, &$result ) );
 768+ wfRunHooks( 'LDAPSetCreationValues', array( $this, $username, &$values, $writeloc, &$this->userdn, &$result ) );
769769 if ( ! $result ) {
770770 $this->printDebug( "Failed to add user because LDAPSetCreationValues returned false", NONSENSITIVE );
771771 @ldap_unbind();

Status & tagging log