r95885 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95884‎ | r95885 | r95886 >
Date:17:01, 31 August 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
followup to r95884
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Table.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Table.php
@@ -33,7 +33,7 @@
3434 */
3535 protected function handleParameters( array $params, $outputmode ) {
3636 parent::handleParameters( $params, $outputmode );
37 - if ( array_key_exists( 'class', $params ) ) {
 37+ if ( $params['class'] !== '' ) {
3838 $this->mHTMLClass = $params['class'];
3939 }
4040 }
@@ -41,6 +41,8 @@
4242 protected function getResultText( SMWQueryResult $res, $outputmode ) {
4343 global $wgVersion;
4444
 45+ $result = '';
 46+
4547 $tableRows = array();
4648
4749 $rowNum = 1;
@@ -203,8 +205,11 @@
204206
205207 public function getParameters() {
206208 $params = array_merge( parent::getParameters(), parent::textDisplayParameters() );
 209+
207210 $params['class'] = new Parameter( 'class', Parameter::TYPE_STRING );
208211 $params['class']->setMessage( 'smw-paramdesc-table-class' );
 212+ $params['class']->setDefault( '' );
 213+
209214 return $params;
210215 }
211216

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95884Added more CSS classes, to enable customization of table appearance - new 'cl...yaron16:31, 31 August 2011