r95841 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95840‎ | r95841 | r95842 >
Date:08:44, 31 August 2011
Author:ckepper
Status:ok
Tags:
Comment:
cleaned up whitespace and indentation according to coding conventions
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -312,7 +312,7 @@
313313 $this->setHeaders();
314314 $wgOut->setPageTitle( wfMsg( 'coll-book_creator' ) );
315315
316 - $wgOut->addWikiMsg( 'coll-book_creator_intro' );
 316+ $wgOut->addWikiMsg( 'coll-book_creator_intro' );
317317
318318 $wgOut->addModules( 'ext.collection.checkLoadFromLocalStorage' );
319319
@@ -393,7 +393,7 @@
394394
395395 $this->setHeaders();
396396 $wgOut->setPageTitle( wfMsg( 'coll-book_creator_disable' ) );
397 - $wgOut->addWikiMsg( 'coll-book_creator_disable_text' );
 397+ $wgOut->addWikiMsg( 'coll-book_creator_disable_text' );
398398
399399 $wgOut->addHTML(
400400 Xml::tags( 'form',
@@ -1059,9 +1059,11 @@
10601060 }
10611061
10621062 $template = new CollectionRenderingTemplate();
1063 - $template->set( 'status', $status );
1064 - if ( !isset( $response['status']['progress'] ) ) $response['status']['progress'] = 1.00;
1065 - $template->set( 'progress', $response['status']['progress'] );
 1063+ $template->set( 'status', $status );
 1064+ if ( !isset( $response['status']['progress'] ) ) {
 1065+ $response['status']['progress'] = 1.00;
 1066+ }
 1067+ $template->set( 'progress', $response['status']['progress'] );
10661068 $wgOut->addTemplate( $template );
10671069 break;
10681070 case 'finished':
@@ -1092,18 +1094,18 @@
10931095
10941096 $info = false;
10951097 if ( isset( $r['url'] ) ) {
1096 - $result = Http::get( $r['url'] );
1097 - if ($result) {
1098 - fwrite($tempfile, $result);
1099 - $info = true;
 1098+ $result = Http::get( $r['url'] );
 1099+ if ($result) {
 1100+ fwrite($tempfile, $result);
 1101+ $info = true;
11001102 }
11011103 $content_type = $r['content_type'];
11021104 $content_length = $r['content_length'];
11031105 $content_disposition = $r['content_disposition'];
11041106 } else {
11051107 $info = self::mwServeCommand( 'download', array(
1106 - 'collection_id' => $wgRequest->getVal( 'collection_id' ),
1107 - 'writer' => $wgRequest->getVal( 'writer' ),
 1108+ 'collection_id' => $wgRequest->getVal( 'collection_id' ),
 1109+ 'writer' => $wgRequest->getVal( 'writer' ),
11081110 ) );
11091111 $content_type = $info['content_type'];
11101112 $content_length = $info['download_content_length'];

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95816fixed bug 24512 (removed curlreq()) and cleaned up parameters for mwServeComm...ckepper22:14, 30 August 2011

Status & tagging log