r95804 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95803‎ | r95804 | r95805 >
Date:19:08, 30 August 2011
Author:wikinaut
Status:ok
Tags:
Comment:
deleted unnecessary RequestContext calls and moved it to the single place where it is needed: displaySuccessLogin()
Modified paths:
  • /trunk/extensions/OpenID/OpenID.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDLogin.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/SpecialOpenIDLogin.body.php
@@ -409,10 +409,7 @@
410410 }
411411
412412 $wgUser = $user;
413 - RequestContext::getMain()->setUser( $wgUser );
414 -
415413 $this->clearValues();
416 -
417414 $this->displaySuccessLogin( $openid );
418415 }
419416
@@ -472,7 +469,6 @@
473470 if ( $user instanceof User ) {
474471 $this->updateUser( $user, $sreg, $ax ); # update from server
475472 $wgUser = $user;
476 - RequestContext::getMain()->setUser( $wgUser );
477473 $this->displaySuccessLogin( $openid );
478474 } else {
479475 // if we are hardcoding nickname, and a valid e-mail address was returned, create a user with this name
@@ -585,6 +581,7 @@
586582 global $wgUser, $wgOut;
587583
588584 $this->setupSession();
 585+ RequestContext::getMain()->setUser( $wgUser );
589586 $wgUser->SetCookies();
590587
591588 # Run any hooks; ignore results
Index: trunk/extensions/OpenID/OpenID.php
@@ -27,7 +27,7 @@
2828 exit( 1 );
2929 }
3030
31 -define( 'MEDIAWIKI_OPENID_VERSION', '0.934-beta' );
 31+define( 'MEDIAWIKI_OPENID_VERSION', '0.935-beta 20110830' );
3232
3333 $path = dirname( __FILE__ );
3434 set_include_path( implode( PATH_SEPARATOR, array( $path ) ) . PATH_SEPARATOR . get_include_path() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95706fixes this annoying bug29543 - After logging in with OpenID, user page link i...wikinaut21:53, 29 August 2011

Status & tagging log