r95765 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95764‎ | r95765 | r95766 >
Date:12:28, 30 August 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Simplify getTasks and remove mention of xliff
Modified paths:
  • /trunk/extensions/Translate/TranslateTasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateTasks.php
@@ -452,17 +452,12 @@
453453 'untranslatedoptional',
454454 'review',
455455 'export-to-file',
456 - 'export-to-xliff'
457456 );
458457
459458 $allTasks = array_keys( $wgTranslateTasks );
460459
461460 if ( $pageTranslation ) {
462 - foreach ( $allTasks as $id => $task ) {
463 - if ( in_array( $task, $filterTasks ) ) {
464 - unset( $allTasks[$id] );
465 - }
466 - }
 461+ $allTasks = array_diff( $allTasks, $filterTasks );
467462 }
468463
469464 if ( !isset( $wgTranslateTranslationServices['tmserver'] ) ) {

Status & tagging log