r95756 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95755‎ | r95756 | r95757 >
Date:11:39, 30 August 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix a message key typo in r41961 (!!), which didn't matter before because the relevant code (and the message) wasn't reachable.
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/TitlePermissionTest.php
@@ -580,7 +580,7 @@
581581 $this->title->userCan( 'move' ) );
582582
583583 $this->title->mInterwiki = "no";
584 - $this->assertEquals( array( array( 'immobile-page' ) ),
 584+ $this->assertEquals( array( array( 'immobile-source-page' ) ),
585585 $this->title->getUserPermissionsErrors( 'move', $this->user ) );
586586 $this->assertEquals( false,
587587 $this->title->userCan( 'move' ) );
Index: trunk/phase3/includes/Title.php
@@ -1555,7 +1555,7 @@
15561556 $errors[] = array( 'immobile-source-namespace', $this->getNsText() );
15571557 } elseif ( !$this->isMovable() ) {
15581558 // Less specific message for rarer cases
1559 - $errors[] = array( 'immobile-page' );
 1559+ $errors[] = array( 'immobile-source-page' );
15601560 }
15611561 } elseif ( $action == 'move-target' ) {
15621562 if ( !MWNamespace::isMovable( $this->mNamespace ) ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r41961* Reintroduce user page move permission as per r41465, generally useful regar...tstarling08:26, 11 October 2008

Status & tagging log