r95687 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95686‎ | r95687 | r95688 >
Date:19:11, 29 August 2011
Author:dale
Status:ok
Tags:
Comment:
fixed typo
removed debug line
Modified paths:
  • /trunk/extensions/TimedMediaHandler/MwEmbedModules/TimedText/resources/mw.TimedText.js (modified) (history)
  • /trunk/extensions/TimedMediaHandler/TranscodeStatusTable.php (modified) (history)
  • /trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TranscodeStatusTable.php
@@ -114,7 +114,7 @@
115115 $doneMsg = wfMsgHtml('timedmedia-percent-done', round( filesize( $filePath ) / $targetSize, 2 ) );
116116 }
117117 } */
118 - // predicting percent done is not working well right now ( disabled for now )
 118+ // Predicting percent done is not working well right now ( disabled for now )
119119 $doneMsg = '';
120120 return wfMsgHtml('timedmedia-started-transcode', TimedMediaHandler::getTimePassedMsg( $timePassed ), $doneMsg );
121121 }
Index: trunk/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscode.php
@@ -658,7 +658,6 @@
659659 */
660660 public static function isTargetLargerThanFile( &$file, $targetMaxSize ){
661661 $maxSize = self::getMaxSize( $targetMaxSize );
662 - print_r($max_size);
663662 $sourceWidth = $file->getWidth();
664663 $sourceHeight = $file->getHeight();
665664 $sourceAspect = intval( $sourceWidth ) / intval( $sourceHeight );
Index: trunk/extensions/TimedMediaHandler/MwEmbedModules/TimedText/resources/mw.TimedText.js
@@ -52,12 +52,12 @@
5353 * The list of enabled sources
5454 */
5555 enabledSources: null,
56 -
 56+
5757 /**
58 - * The current langauge key
 58+ * The current language key
5959 */
6060 currentLangKey : null,
61 -
 61+
6262 /**
6363 * Stores the last text string per category to avoid dom checks
6464 * for updated text
@@ -150,7 +150,7 @@
151151 $( embedPlayer ).bind( 'play', function() {
152152 // Will load and setup timedText sources (if not loaded already loaded )
153153 _this.setupTextSources();
154 - } );
 154+ } );
155155
156156 // Resize the timed text font size per window width
157157 $( embedPlayer ).bind( 'onCloseFullScreen onOpenFullScreen', function() {
@@ -898,7 +898,7 @@
899899 * Updates the timed text layout ( should be called when config.layout changes )
900900 */
901901 updateLayout: function() {
902 - var $playerTarget = this.embedPlayer.$interface;
 902+ var $playerTarget = this.embedPlayer.$interface;
903903 $playerTarget.find('.track').remove();
904904 this.refreshDisplay();
905905 },
@@ -1427,6 +1427,10 @@
14281428 var content, start, end, s;
14291429 caption = caplist[i];
14301430 s = caption.split(/\n/);
 1431+ if (s.length < 2) {
 1432+ // file format error or comment lines
 1433+ continue;
 1434+ }
14311435 if (s[0].match(/^\d+$/) && s[1].match(/\d+:\d+:\d+/)) {
14321436 // ignore caption number in s[0]
14331437 // parse time string

Status & tagging log