r95644 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95643‎ | r95644 | r95645 >
Date:02:24, 29 August 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Followup r95642, messages are added to RL before they can be customized
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -176,7 +176,6 @@
177177 $wgResourceModules['ext.codereview.tooltips'] = array(
178178 'scripts' => 'ext.codereview.tooltips.js',
179179 'dependencies' => 'jquery.tipsy',
180 - 'messages' => array_merge( CodeRevision::getPossibleStateMessageKeys(), array( 'code-tooltip-withsummary', 'code-tooltip-withoutsummary' ) ),
181180 ) + $commonModuleInfo;
182181
183182 // Revision 'scapmap':
@@ -370,3 +369,14 @@
371370 }
372371 return true;
373372 }
 373+
 374+# Add state messages to RL
 375+$wgExtensionFunctions[] = 'efCodeReviewAddTooltipMessages';
 376+
 377+function efCodeReviewAddTooltipMessages() {
 378+ global $wgResourceModules;
 379+
 380+ $wgResourceModules['ext.codereview.tooltips']['messages'] = array_merge(
 381+ CodeRevision::getPossibleStateMessageKeys(),
 382+ array( 'code-tooltip-withsummary', 'code-tooltip-withoutsummary' ) );
 383+}

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90902* (bug 28259) Localise CR Tooltipsreedy20:03, 27 June 2011
r95642Making revision states, protected states, and flags configurablejohnduhart01:56, 29 August 2011

Status & tagging log