r95639 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95638‎ | r95639 | r95640 >
Date:22:15, 28 August 2011
Author:ariel
Status:deferred
Tags:
Comment:
lose empty options from dumpTextPass runs
Modified paths:
  • /branches/ariel/xmldumps-backup/worker.py (modified) (history)

Diff [purge]

Index: branches/ariel/xmldumps-backup/worker.py
@@ -2750,12 +2750,12 @@
27512751 prefetch = "--prefetch=%s" % (source)
27522752 else:
27532753 runner.showRunnerState("... building %s %s XML dump, no text prefetch..." % (self._subset, chunkinfo))
2754 - prefetch = None
 2754+ prefetch = ""
27552755
27562756 if self._spawn:
27572757 spawn = "--spawn=%s" % (runner.wiki.config.php)
27582758 else:
2759 - spawn = None
 2759+ spawn = ""
27602760
27612761 if (not exists( runner.wiki.config.php ) ):
27622762 raise BackupError("php command %s not found" % runner.wiki.config.php)
@@ -2764,8 +2764,8 @@
27652765 checkpointTime = "--maxtime=%s" % (runner.wiki.config.checkpointTime)
27662766 checkpointFile = "--checkpointfile=%s" % outputFile.newFilename(outputFile.dumpName, outputFile.fileType, outputFile.fileExt, outputFile.date, outputFile.chunk, "p%sp%s", None)
27672767 else:
2768 - checkpointTime = None
2769 - checkpointFile = None
 2768+ checkpointTime = ""
 2769+ checkpointFile = ""
27702770 dumpCommand = [ "%s" % runner.wiki.config.php,
27712771 "-q", "%s/maintenance/dumpTextPass.php" % runner.wiki.config.wikiDir,
27722772 "--wiki=%s" % runner.dbName,
@@ -2777,6 +2777,7 @@
27782778 "--report=1000",
27792779 "%s" % spawn ]
27802780
 2781+ dumpCommand = filter(None, dumpCommand)
27812782 command = dumpCommand
27822783 filters = self.buildFilters(runner, outputFile)
27832784 eta = self.buildEta(runner)

Status & tagging log