r95637 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95636‎ | r95637 | r95638 >
Date:21:21, 28 August 2011
Author:ckepper
Status:ok
Tags:
Comment:
fixed a few minor bugs in the Collection extension: bug 21070, bug 28060, bug 28118
Modified paths:
  • /trunk/extensions/Collection/Collection.body.php (modified) (history)
  • /trunk/extensions/Collection/Collection.templates.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.body.php
@@ -510,7 +510,7 @@
511511
512512 static function addChapter( $name ) {
513513 $collection = CollectionSession::getCollection();
514 - array_unshift( $collection['items'], array(
 514+ array_push( $collection['items'], array(
515515 'type' => 'chapter',
516516 'title' => $name,
517517 ) );
Index: trunk/extensions/Collection/Collection.templates.php
@@ -12,7 +12,7 @@
1313 */
1414 class CollectionPageTemplate extends QuickTemplate {
1515 function execute() {
16 - $mediapath = $GLOBALS['wgScriptPath'] . '/extensions/Collection/images/';
 16+ $mediapath = $GLOBALS['wgExtensionAssetsPath'] . '/Collection/images/';
1717 ?>
1818
1919 <div class="mw-float-start collection-column collection-column-left">
@@ -53,7 +53,7 @@
5454
5555 <div class="mw-float-start collection-column collection-column-right">
5656
57 - <div class="collection-column-right-box">
 57+ <div class="collection-column-right-box" id="coll-orderbox">
5858 <h2><span class="mw-headline"><?php $this->msg( 'coll-book_title' ) ?></span></h2>
5959 <?php
6060 $partnerData = $this->data['podpartners']['pediapress'];
@@ -90,7 +90,7 @@
9191 <?php } ?>
9292 </div>
9393
94 - <div class="collection-column-right-box">
 94+ <div class="collection-column-right-box" id="coll-downloadbox">
9595 <h2><span class="mw-headline"><?php $this->msg( 'coll-download_title' ) ?></span></h2>
9696 <?php if ( count( $this->data['formats'] ) == 1 ) {
9797 $writer = array_rand( $this->data['formats'] );

Status & tagging log