| Index: trunk/extensions/ClickTracking/ClickTracking.hooks.php |
| — | — | @@ -96,16 +96,17 @@ |
| 97 | 97 | global $wgResourceModules; |
| 98 | 98 | |
| 99 | 99 | $cusResourceTemplate = array( |
| 100 | | - 'localBasePath' => $localBasePath, |
| 101 | | - 'remoteExtPath' => $remoteExtPath, |
| | 100 | + 'localBasePath' => $localBasePath, |
| | 101 | + 'remoteExtPath' => $remoteExtPath, |
| 102 | 102 | ); |
| 103 | 103 | $wgResourceModules["ext.UserBuckets.$name"] = array( |
| 104 | 104 | 'scripts' => "$name.js", |
| 105 | 105 | 'dependencies' => 'jquery.clickTracking', |
| 106 | 106 | ) + $cusResourceTemplate; |
| 107 | 107 | $wgResourceModules['ext.UserBuckets']['dependencies'] = array_merge( |
| 108 | | - ( array ) $wgResourceModules['ext.UserBuckets']['dependencies'], |
| 109 | | - array("ext.UserBuckets.$name")); |
| | 108 | + ( array ) $wgResourceModules['ext.UserBuckets']['dependencies'], |
| | 109 | + array( "ext.UserBuckets.$name" ) |
| | 110 | + ); |
| 110 | 111 | } |
| 111 | 112 | |
| 112 | 113 | /** |
| — | — | @@ -225,9 +226,9 @@ |
| 226 | 227 | $db_status_buckets = $db_status_buckets && $db_current_bucket_insert; |
| 227 | 228 | } |
| 228 | 229 | }//ifbuckets |
| | 230 | + $dbw->commit(); |
| 229 | 231 | }//ifrecord |
| 230 | 232 | |
| 231 | | - $dbw->commit(); |
| 232 | 233 | $retval = $db_status && $db_status_buckets; |
| 233 | 234 | } |
| 234 | 235 | if ( $wgClickTrackingLog ) { |
| Index: trunk/extensions/ClickTracking/modules/sampleCampaign.js |
| — | — | @@ -44,6 +44,7 @@ |
| 45 | 45 | // "allActive" is reserved. |
| 46 | 46 | // If this function exists, it will be apply to every user not in the "none" bucket |
| 47 | 47 | allActive: function(){ |
| | 48 | + // FIXME: Calling trackAction() from a click handler of a button that submits a form DOES NOT WORK cross-browser |
| 48 | 49 | // Add click tracking to save |
| 49 | 50 | jQuery( '#wpSave' ).click(function(){ jQuery.trackAction( 'save' ); }); |
| 50 | 51 | // Add click tracking to preview |