r95611 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95610‎ | r95611 | r95612 >
Date:21:46, 27 August 2011
Author:robin
Status:ok
Tags:
Comment:
Properly mark the language and direction of the readonly textarea
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2087,12 +2087,15 @@
20882088 if( is_string( $source ) ) {
20892089 $this->addWikiMsg( 'viewsourcetext' );
20902090
 2091+ $pageLang = $this->getTitle()->getPageLanguage();
20912092 $params = array(
20922093 'id' => 'wpTextbox1',
20932094 'name' => 'wpTextbox1',
20942095 'cols' => $this->getUser()->getOption( 'cols' ),
20952096 'rows' => $this->getUser()->getOption( 'rows' ),
2096 - 'readonly' => 'readonly'
 2097+ 'readonly' => 'readonly',
 2098+ 'lang' => $pageLang->getCode(),
 2099+ 'dir' => $pageLang->getDir(),
20972100 );
20982101 $this->addHTML( Html::element( 'textarea', $params, $source ) );
20992102

Sign-offs

UserFlagDate
MZMcBrideinspected22:42, 27 August 2011

Status & tagging log