r95480 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95479‎ | r95480 | r95481 >
Date:12:24, 25 August 2011
Author:reedy
Status:deferred
Tags:
Comment:
Followup r95454

Fix whitespace, remove irrelevant comments

Add code to loader
Modified paths:
  • /trunk/extensions/MetricsReporting/MetricsReporting.php (modified) (history)
  • /trunk/extensions/MetricsReporting/metrics/EditorsByGeographyMetric.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/MetricsReporting.php
@@ -64,3 +64,6 @@
6565
6666 $wgAutoloadClasses['SquidPageViewsMetric'] = $metricsDir . 'SquidPageViewsMetric.php';
6767 $wgMetricAPIModules['squidpageviews'] = 'SquidPageViewsMetric';
 68+
 69+$wgAutoloadClasses['EditorsByGeographyMetric'] = $metricsDir . 'EditorsByGeographyMetric.php';
 70+$wgMetricAPIModules['editorsbygeography'] = 'EditorsByGeographyMetric';
Index: trunk/extensions/MetricsReporting/metrics/EditorsByGeographyMetric.php
@@ -1,22 +1,16 @@
22 <?php
33
44 /**
5 - * Subclass this, pass the table name to the constructor, then just override
6 - * the getDescription and getExamples functions
75 *
8 - * Then add it to the loader
96 */
107 class EditorsByGeographyMetric extends GenericMetricBase {
11 -
12 -
138 /**
149 * @param $tableName string
1510 */
1611 function __construct() {
17 - parent::__construct("editorsbygeography");
 12+ parent::__construct( 'editorsbygeography' );
1813 }
1914
20 -
2115 public function getDescription(){
2216 return "Number of active unique registered editors by country";
2317 }
@@ -24,6 +18,4 @@
2519 protected function getExamples(){
2620 return "";
2721 }
28 -
29 -
3022 }
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95454adding EditorsByGeography metricnimishg22:36, 24 August 2011

Status & tagging log