r95450 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95449‎ | r95450 | r95451 >
Date:21:55, 24 August 2011
Author:johnduhart
Status:ok
Tags:
Comment:
Follow-up r95445, fix for IE6-7 no supporting display-inline. Removes alt attribute left over from using the img tag
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.spinner.css (modified) (history)
  • /trunk/phase3/resources/jquery/jquery.spinner.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.spinner.css
@@ -5,4 +5,8 @@
66 width: 20px;
77 display: inline-block;
88 vertical-align: middle;
 9+
 10+ /* IE < 8 Hacks */
 11+ zoom: 1;
 12+ *display: inline;
913 }
\ No newline at end of file
Index: trunk/phase3/resources/jquery/jquery.spinner.js
@@ -16,8 +16,7 @@
1717 return $( '<div>' ).attr( {
1818 id: 'mw-spinner-' + id,
1919 'class': 'mw-spinner',
20 - title: '...',
21 - alt: '...'
 20+ title: '...'
2221 } );
2322 },
2423

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95445(bug 30499) Create jQuery replacements for injectSpinner and removeSpinnerjohnduhart21:08, 24 August 2011

Status & tagging log