r95433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95432‎ | r95433 | r95434 >
Date:19:53, 24 August 2011
Author:hashar
Status:ok
Tags:
Comment:
makes CodeRevisionView::formatComment() public

That method should really be moved out of the view object. For example,
we could use a generic helping class that each view can reuse.
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
——@@ -741,7 +741,7 @@
742742 * @param string $replyForm
743743 * @return string
744744 */
745 - protected function formatComment( $comment, $replyForm = '' ) {
 745+ public function formatComment( $comment, $replyForm = '' ) {
746746 global $wgOut, $wgLang, $wgContLang;
747747
748748 if ( $comment->id === 0 ) {

Status & tagging log