r95315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95314‎ | r95315 | r95316 >
Date:17:58, 23 August 2011
Author:brion
Status:ok
Tags:
Comment:
Followup r95262 - remove bogus test cases that seemed to be trying to test the browser's HTML fragment parser. :)

These test cases attempted, I think, to be bogus forced-fail cases, but the fail-forcing doesn't work because HTML 5 parsing in modern browsers parses the text into... the same as the actual expected text! :)
Resolves bug 30520.
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/jquery/jquery.highlightText.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/jquery/jquery.highlightText.test.js
——@@ -156,18 +156,6 @@
157157 text: "« L'oiseau est sur l’île »",
158158 highlight: "« L'oise",
159159 expected: '<span class="highlight">«</span> <span class="highlight">L\'oise</span>au est sur l’île »'
160 - },
161 - {
162 - desc: 'Test 100: TESTCASE FOR QUNIT FAILS: a wrong expected string was not detected in Firefox 6.0 and Chrome',
163 - text: 'Österreich',
164 - highlight: 'Ö',
165 - expected: '<span class="highlight">Ö</span>sterreich</span this wrong tag is not detected as test failure in Firefox 6.0 or Chrome>'
166 - },
167 - {
168 - desc: 'Test 101: TESTCASE FOR QUNIT FAILS: a wrong expected string was not detected in Firefox 6.0 or Chrome',
169 - text: 'Oesterreich',
170 - highlight: 'Oe',
171 - expected: '<span class="highlight">Oe</span>sterreich</span this wrong tag is not detected as test failure in Firefox 6.0 or Chrome>'
172160 }
173161 ];
174162 expect(cases.length);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95262follow up to r94807 : more test cases incl. hebrew RTL and Japanese, the test...wikinaut22:15, 22 August 2011

Status & tagging log