r95201 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95200‎ | r95201 | r95202 >
Date:13:24, 22 August 2011
Author:akshay
Status:ok
Tags:
Comment:
Followup r95185, fixed braces, escaped values for the ajax call params
Modified paths:
  • /trunk/extensions/SignupAPI/includes/verification.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SignupAPI/includes/verification.js
@@ -6,7 +6,7 @@
77 $.ajax({
88 type: "POST",
99 url: mw.util.wikiScript('api'),
10 - data: "action=validatesignup&format=json&field="+fieldtype+"&inputVal="+inputVal,
 10+ data: {'action':'validatesignup', 'format':'json', 'field':fieldtype, 'inputVal':inputVal },
1111 dataType: 'json',
1212 success: function( jsondata ){
1313 var image = "<img src='"+ imagePath + jsondata.signup.icon +"'>";
@@ -53,8 +53,7 @@
5454 if ( pass==retype ) {
5555 image = "<img src='"+ imagePath +"MW-Icon-CheckMark.png'>";
5656 message = mw.message( 'signupapi-passwordsmatch' );
57 - }
58 - else {
 57+ }else {
5958 image = "<img src='"+ imagePath +"MW-Icon-NoMark.png'>";
6059 message = mw.message( 'badretype' );
6160 }
@@ -71,10 +70,7 @@
7271 $('#wpRetype').after('<span id="wpRetypeval" class="wpRetypeval"></span>');
7372 $('#wpEmail').after('<span id="wpEmailval" class="wpEmailval"></span>');
7473
75 -mw.loader.using( 'ext.SignupAPI', function() {
76 - $("#progress").progressbar();
77 - } );
78 -
 74+$("#progress").progressbar();
7975 console.log();
8076 $('div.ui-progressbar').css('background','#F2F5F7');
8177

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95185Added resources for AJAX-ifying the signup form...akshay00:34, 22 August 2011

Status & tagging log