r95153 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95152‎ | r95153 | r95154 >
Date:17:12, 21 August 2011
Author:ankitgarg833
Status:deferred
Tags:
Comment:
changing tag from Filter to semanticrilldown_Flter, to avoid namespace issue.
Modified paths:
  • /trunk/extensions/SemanticDrilldown/includes/SD_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/includes/SD_Utils.php
@@ -14,7 +14,7 @@
1515 */
1616 public static function createPageSchemasObject( $objectName, $xmlForField, &$object ) {
1717 $sdarray = array();
18 - if ( $objectName == "Filter" ) {
 18+ if ( $objectName == "semanticdrilldown_Filter" ) {
1919 foreach ( $xmlForField->children() as $tag => $child ) {
2020 if ( $tag == $objectName ) {
2121 foreach ( $child->children() as $prop => $value) {
@@ -69,7 +69,7 @@
7070 foreach( $field_all as $field ) {
7171 $html_text .= '<fieldset style="background: #FDD;"><legend>Filter</legend>';
7272 $field_count++;
73 - $sd_array = $field->getObject('Filter');//this returns an array with property values filled
 73+ $sd_array = $field->getObject('semanticdrilldown_Filter');//this returns an array with property values filled
7474 $filter_array = $sd_array['sd'];
7575 $html_text .= '<p>'.$name_label.' <input size="25" name="sd_filter_name_starter" value="'.$filter_array['Label'].'" ></p>';
7676 $html_text .= '<p><input type="radio" name="sd_values_source_starter" checked value="property">'.
@@ -187,7 +187,7 @@
188188 $xml_text_array = array();
189189 foreach ( $wgRequest->getValues() as $var => $val ) {
190190 if(substr($var,0,15) == 'sd_filter_name_'){
191 - $Xmltext .= '<semanticdrilldown:Filter>';
 191+ $Xmltext .= '<semanticdrilldown_Filter>';
192192 $templateNum = substr($var,15,1);
193193 $Xmltext .= '<Label>'.$val.'</Label>';
194194 }else if(substr($var,0,17) == 'sd_values_source_'){
@@ -212,7 +212,7 @@
213213 }
214214 }else if( substr($var,0,14) == 'sd_input_type_'){
215215 $Xmltext .= '<InputType>'.$val.'</InputType>';
216 - $Xmltext .= '</semanticdrilldown:Filter>';
 216+ $Xmltext .= '</semanticdrilldown_Filter>';
217217 $xml_text_array[] = $Xmltext;
218218 $Xmltext = '';
219219 }
@@ -298,7 +298,7 @@
299299 */
300300 public static function parseFieldElements( $field_xml, &$text_object ) {
301301 foreach ( $field_xml->children() as $tag => $child ) {
302 - if ( $tag == "Filter" ) {
 302+ if ( $tag == "semanticdrilldown_Filter" ) {
303303 $text = "";
304304 $text = PageSchemas::tableMessageRowHTML( "paramAttr", "SemanticDrillDown", (string)$tag );
305305 foreach ( $child->children() as $prop => $value) {