r95094 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95093‎ | r95094 | r95095 >
Date:15:40, 20 August 2011
Author:jeroendedauw
Status:ok
Tags:lamecommitsummary 
Comment:
Modified paths:
  • /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history)
  • /trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/UploadWizardCampaign.php
@@ -295,7 +295,7 @@
296296
297297 foreach ( $config as $settingName => &$settingValue ) {
298298 if ( is_array( $defaultConfig[$settingName]['default'] ) && !is_array( $settingValue ) ) {
299 - $parts = explode( ', ', $settingValue );
 299+ $parts = explode( '| ', $settingValue );
300300 $settingValue = array();
301301
302302 foreach ( $parts as $part ) {
@@ -485,7 +485,7 @@
486486 array(
487487 'cc_campaign_id' => $this->id,
488488 'cc_property' => $prop,
489 - 'cc_value' => is_array( $value ) ? implode( ', ', $value ) : $value
 489+ 'cc_value' => is_array( $value ) ? implode( '| ', $value ) : $value
490490 )
491491 );
492492 }
Index: trunk/extensions/UploadWizard/UploadWizard.i18n.php
@@ -311,8 +311,8 @@
312312 'mwe-upwiz-campaign-name' => 'Campaign name',
313313 'mwe-upwiz-campaign-enabled' => 'Campaign enabled',
314314 'mwe-upwiz-campaign-conf-skipTutorial' => 'Skip the licensing tutorial',
315 - 'mwe-upwiz-campaign-conf-autoCategories' => 'Categories to add the files to automatically and silently (comma separated)',
316 - 'mwe-upwiz-campaign-conf-defaultCategories' => 'Default categories to list in the describe tab (comma separated)',
 315+ 'mwe-upwiz-campaign-conf-autoCategories' => 'Categories to add the files to automatically and silently (pipe separated)',
 316+ 'mwe-upwiz-campaign-conf-defaultCategories' => 'Default categories to list in the describe tab (pipe separated)',
317317 'mwe-upwiz-campaign-conf-autoWikiText' => 'WikiText to automatically add to all uploaded images',
318318 'mwe-upwiz-campaign-conf-ownWorkOption' => 'How to handle own-work or not own-work',
319319 'mwe-upwiz-campaign-owner-choice' => 'Allow the user to choose between own work and non-own work',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95033added warnings when trying to use invalid or disabled campaign and added head...jeroendedauw19:29, 19 August 2011

Status & tagging log