r95076 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95075‎ | r95076 | r95077 >
Date:11:08, 20 August 2011
Author:ankitgarg833
Status:ok (Comments)
Tags:
Comment:
changing color of fieldset
Modified paths:
  • /trunk/extensions/SemanticDrilldown/includes/SD_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/includes/SD_Utils.php
——@@ -142,7 +142,6 @@
143143 $enter_values_label.' <input size="40" name="sd_filter_values_starter" value="">
144144 </p>';
145145 }
146 -
147146 if( $filter_array['InputType'] != null){
148147 $input_type_val = $filter_array['InputType'];
149148 $html_text .= '<p>'.$input_type_label.'

Comments

#Comment by Nikerabbit (talk | contribs)   13:55, 20 August 2011

Change does not match commit message.

#Comment by Jeroen De Dauw (talk | contribs)   20:42, 20 August 2011

It's a null-commit, so marking it as fixme is rather odd :)

#Comment by Nikerabbit (talk | contribs)   20:45, 20 August 2011

Just trying to teach some good practices, no success yet.

#Comment by Johnduhart (talk | contribs)   20:45, 20 August 2011

It's expected that the committer would follow up and/or explain on CR in this case.

#Comment by Ankitgarg (talk | contribs)   16:43, 25 August 2011

Hi, 

  I was quite new to using the svn, hence all this mess. Apologies.

Status & tagging log