r95073 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95072‎ | r95073 | r95074 >
Date:10:25, 20 August 2011
Author:catrope
Status:ok
Tags:
Comment:
Fix serious bug in r90849 that didn't show up in the tests until I restructured the code a bit and the tests started to actually hit it: $url is undefined, use $href
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -1156,7 +1156,7 @@
11571157
11581158 // Parser::getExternalLinkAttribs won't work here because of the Namespace things
11591159 global $wgNoFollowLinks, $wgNoFollowDomainExceptions;
1160 - if ( $wgNoFollowLinks && !wfMatchesDomainList( $url, $wgNoFollowDomainExceptions ) ) {
 1160+ if ( $wgNoFollowLinks && !wfMatchesDomainList( $href, $wgNoFollowDomainExceptions ) ) {
11611161 $extraAttribs['rel'] = 'nofollow';
11621162 }
11631163

Follow-up revisions

RevisionCommit summaryAuthorDate
r95632MFT to REL1_18...hashar17:57, 28 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r90849Apply rgcjones' patch for Bug#29533:...mah19:52, 26 June 2011

Status & tagging log