r95066 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95065‎ | r95066 | r95067 >
Date:06:02, 20 August 2011
Author:ankitgarg833
Status:deferred
Tags:
Comment:
<fieldset position fix.
Modified paths:
  • /trunk/extensions/SemanticDrilldown/includes/SD_Utils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/includes/SD_Utils.php
@@ -142,7 +142,8 @@
143143 $enter_values_label.' <input size="40" name="sd_filter_values_starter" value="">
144144 </p>';
145145 }
146 - if( $filter_array['InputType'] != null){
 146+
 147+ if( $filter_array['InputType'] != null){
147148 $input_type_val = $filter_array['InputType'];
148149 $html_text .= '<p>'.$input_type_label.'
149150 <select id="input_type_dropdown" name="sd_input_type_starter">
@@ -151,19 +152,29 @@
152153 $html_text .= '<option selected value="'.$combo_box_value.'">'.$combo_box_label.'</option>
153154 <option value="'.$date_range_value.'">'.$date_range_label.'</option>
154155 </select>
155 - </p></fieldset>';
 156+ </p>';
156157 }else if( $input_type_val == $date_range_value ){
157158 $html_text .= '<option value="'.$combo_box_value.'">'.$combo_box_label.'</option>
158159 <option selected value="'.$date_range_value.'">'.$date_range_label.'</option>
159160 </select>
160 - </p></fieldset>';
 161+ </p>';
161162 }else{
162163 $html_text .= '<option value="'.$combo_box_value.'">'.$combo_box_label.'</option>
163164 <option value="'.$date_range_value.'">'.$date_range_label.'</option>
164165 </select>
165 - </p></fieldset>';
 166+ </p>';
166167 }
167 - }
 168+ }else{
 169+ $html_text .= '<p>'.$input_type_label.'
 170+ <select id="input_type_dropdown" name="sd_input_type_starter">
 171+ <option selected value="">'.$values_list_label.'</option>';
 172+ $html_text .= '<option value="'.$combo_box_value.'">'.$combo_box_label.'</option>
 173+ <option value="'.$date_range_value.'">'.$date_range_label.'</option>
 174+ </select>
 175+ </p>';
 176+ }
 177+
 178+ $html_text .= '</fieldset>';
168179 $html_text_array[] = $html_text;
169180 $html_text = "";
170181 }
@@ -215,7 +226,7 @@
216227 global $wgContLang;
217228
218229 $text = "";
219 - $text .= '<fieldset style="background: #FF0080;"><legend>Filter</legend>';
 230+ $text .= '<fieldset style="background: #FDD;"><legend>Filter</legend>';
220231 $name_label = wfMsg( 'sd_createfilter_name' );
221232 $property_label = wfMsg( 'sd_createfilter_property' );
222233 $label_label = wfMsg( 'sd_createfilter_label' );