r94915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94914‎ | r94915 | r94916 >
Date:18:43, 18 August 2011
Author:inez
Status:deferred
Tags:
Comment:
Lets be more strict about comparing objects
Modified paths:
  • /trunk/parsers/wikidom/lib/es/es.ListBlock.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/es/es.ListBlock.js
@@ -235,10 +235,10 @@
236236 // delete all selected items except first one
237237 var deleting = false;
238238 for ( var i = 0; i < this.list.items.length; i++ ) {
239 - if ( this.list.items[i] == locationStart.item ) {
 239+ if ( this.list.items[i] === locationStart.item ) {
240240 deleting = true;
241241 continue;
242 - } else if ( this.list.items[i] == locationEnd.item ) {
 242+ } else if ( this.list.items[i] === locationEnd.item ) {
243243 this.list.items[i].list.remove( this.list.items[i] );
244244 break;
245245 }

Status & tagging log