r94912 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94911‎ | r94912 | r94913 >
Date:18:22, 18 August 2011
Author:reedy
Status:deferred
Tags:
Comment:
Uncomment relevant feed to use

Remove trailing comma from GenericDataTable.sql
Modified paths:
  • /trunk/extensions/MetricsReporting/GenericDataTable.sql (modified) (history)
  • /trunk/extensions/MetricsReporting/fetchGoogleSpreadsheet.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/fetchGoogleSpreadsheet.php
@@ -66,7 +66,7 @@
6767 //$src = $node->link[2]->attributes()->href;
6868
6969 // List based feed
70 - // $src = (string)$node->content["src"];
 70+ $src = (string)$node->content["src"];
7171 // $src = $node->content->attributes()->src;
7272
7373 // Cell based feed
Index: trunk/extensions/MetricsReporting/GenericDataTable.sql
@@ -4,6 +4,6 @@
55 `project_code` varchar (10) DEFAULT NULL,
66 `country_code` varchar (3) DEFAULT NULL,
77 `value` bigint (12),-- Needs to be decimal?
8 - PRIMARY KEY ( date, language_code, project_code, country_code, value ),
 8+ PRIMARY KEY ( date, language_code, project_code, country_code, value )
99 -- More indexes may be needed where language, project and country could be null
1010 ) ;
\ No newline at end of file

Status & tagging log