r94884 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94883‎ | r94884 | r94885 >
Date:12:32, 18 August 2011
Author:jlemley
Status:deferred
Tags:
Comment:
Reverted
Modified paths:
  • /trunk/extensions/Favorites/Favorites.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Favorites/Favorites.php
@@ -22,12 +22,11 @@
2323 'name' => 'Favorites',
2424 'author' => 'Jeremy Lemley',
2525 'descriptionmsg' => 'favorites-desc',
26 - 'version' => '0.2.5',
 26+ 'version' => '0.2.2',
2727 'url' => "http://www.mediawiki.org/wiki/Extension:Favorites",
2828 );
2929
30 -global $wgUseIconFavorite, $wgFavoritesPersonalURL;
31 -
 30+global $wgUseIconFavorite;
3231 $dir = dirname(__FILE__) . '/';
3332 $wgExtensionMessagesFiles['Favorites'] = $dir . 'favorites.i18n.php';
3433 $wgAutoloadClasses['Favorites'] = $dir . 'Favorites_body.php';
@@ -63,32 +62,7 @@
6463 $wgHooks['TitleMoveComplete'][] = 'fnHookMoveToFav';
6564 $wgHooks['ArticleDeleteComplete'][] = 'fnHookDeleteFav';
6665
67 -// Do we want to display a "My Favorites" link in the personal urls area?
68 -if ($wgFavoritesPersonalURL) {
69 - $wgHooks['PersonalUrls'][] = 'onAddPersonalUrls';
70 -}
7166
72 -function onAddPersonalUrls( &$personal_urls, &$wgTitle ) {
73 - global $wgUser;
74 -
75 - // $skin = $wgUser->getSkin();
76 -
77 - if( $wgUser->getID() ) {
78 - $url['userpage'] = array_shift( $personal_urls );
79 - $url[] = array_shift( $personal_urls );
80 - $url[] = array_shift( $personal_urls );
81 -
82 - $url[] = array( 'text' => wfMsg( 'myfavoritelist' ),
83 - 'href' => Skin::makeKnownUrlDetails( 'Special:Favoritelist' )
84 - );
85 -
86 -
87 - $personal_urls = $url + $personal_urls;
88 - }
89 -
90 - return true;
91 -}
92 -
9367 function fnAction ($action, $article) {
9468 $title = new Title();
9569 $favArticle = new FavArticle($title);

Status & tagging log