r94880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94879‎ | r94880 | r94881 >
Date:09:53, 18 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
width correction for inputboxes under "show more options"
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php
@@ -1675,7 +1675,7 @@
16761676 Html::rawElement(
16771677 'div',
16781678 array(
1679 - 'style' => 'width: 30%; padding: 5px; float: left;'
 1679+ 'style' => 'width: 30%; min-width:220px; margin:5px; padding: 1px; float: left;'
16801680 ),
16811681 '<label for="p[' . htmlspecialchars( $param->getName() ) . ']">' . htmlspecialchars( $param->getName() ) . ': </label>' .
16821682 $this->showFormatOption( $param, $currentValue ) .
Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -229,21 +229,21 @@
230230 }
231231 $result = '<fieldset><legend>' . wfMsg( 'smw_ask_otheroptions' ) . "</legend>\n" .
232232 Html::rawElement( 'div',
233 - array( 'style' => 'width: 30%; padding: 5px; float: left;' ),
 233+ array( 'style' => 'width: 30%; min-width:220px; margin:5px; padding: 1px; float: left;' ),
234234 wfMsg( 'smw_qc_intro' ) .
235 - '<input name="p[intro]" value="' . $intro . '"size="32"/> <br/>' .
 235+ '<input name="p[intro]" value="' . $intro . '" style="width:220px;"/> <br/>' .
236236 wfMsg( 'smw_paramdesc_intro' )
237237 ) .
238238 Html::rawElement( 'div',
239 - array( 'style' => 'width: 30%; padding: 5px; float: left;' ),
 239+ array( 'style' => 'width: 30%; min-width:220px; margin:5px; padding: 1px; float: left;' ),
240240 wfMsg( 'smw_qc_outro' ) .
241 - '<input name="p[outro]" value="' . $outro . '" size="32"/> <br/>' .
 241+ '<input name="p[outro]" value="' . $outro . '" style="width:220px;"/> <br/>' .
242242 wfMsg( 'smw_paramdesc_outro' )
243243 ) .
244244 Html::rawElement( 'div',
245 - array( 'style' => 'width: 30%; padding: 5px; float: left;' ),
 245+ array( 'style' => 'width: 30%; min-width:220px; margin:5px; padding: 1px; float: left;' ),
246246 wfMsg( 'smw_qc_default' ) .
247 - '<input name="p[default]" value="' . $default . '" size="32"/> <br/>' .
 247+ '<input name="p[default]" value="' . $default . '" style="width:220px;" /> <br/>' .
248248 wfMsg( 'smw_paramdesc_default' )
249249 ) .
250250 Html::hidden( 'p[limit]', $limit ) .