r94871 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94870‎ | r94871 | r94872 >
Date:06:10, 18 August 2011
Author:nad
Status:deferred
Tags:
Comment:
allow any nonempty value for sortable
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -957,7 +957,7 @@
958958 elseif( $k == 'groupby' ) $groupby = $v;
959959 elseif( $k == 'format' ) $format = $v;
960960 elseif( $k == 'cols' ) $cols = self::split( $v, ',' );
961 - elseif( $k == 'sortable' ) $sortable = preg_match( "/(1|yes|true|on)/i", $v );
 961+ elseif( $k == 'sortable' ) $sortable = !empty( $v );
962962 elseif( $k == 'template' ) $template = $v;
963963 elseif( $k == 'count' ) $count = $v;
964964 elseif( $k == 'export' ) $export = $v;

Status & tagging log