r94862 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r94861‎ | r94862 | r94863 >
Date:03:53, 18 August 2011
Author:bawolff
Status:ok
Tags:
Comment:
follow-up r91885 rename testTiffFile since its not about tiff files

This is probably what was referred to in CR, not what I changed in r94825
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/media/JpegTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/media/JpegTest.php
——@@ -13,7 +13,7 @@
1414 $res = $jpeg->getMetadata( null, $this->filePath . 'README' );
1515 $this->assertEquals( ExifBitmapHandler::BROKEN_FILE, $res );
1616 }
17 - public function testTiffFile() {
 17+ public function testJpegMetadataExtraction() {
1818 if ( !wfDl( 'exif' ) ) {
1919 $this->markTestIncomplete( "This test needs the exif extension." );
2020 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r95607MFT to REL1_18...hashar19:28, 27 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91885(follow-up r90256) Unit tests.bawolff16:42, 11 July 2011
r94825follow-up r91885 - address CR comments...bawolff21:53, 17 August 2011

Status & tagging log