r94844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94843‎ | r94844 | r94845 >
Date:23:21, 17 August 2011
Author:neilk
Status:ok
Tags:
Comment:
remove dead UploadWizardDependencyLoader code
Modified paths:
  • /trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/includes/specials/SpecialUploadWizard.php
@@ -45,8 +45,7 @@
4646 * @param $subPage, e.g. the "foo" in Special:UploadWizard/foo.
4747 */
4848 public function execute( $subPage ) {
49 - global $wgRequest, $wgLang, $wgUser, $wgOut, $wgExtensionAssetsPath,
50 - $wgUploadWizardDisableResourceLoader;
 49+ global $wgRequest, $wgLang, $wgUser, $wgOut;
5150
5251 // side effects: if we can't upload, will print error page to wgOut
5352 // and return false
@@ -76,19 +75,7 @@
7776 $this->addJsVars( $subPage );
7877
7978 // dependencies (css, js)
80 - if ( !$wgUploadWizardDisableResourceLoader && class_exists( 'ResourceLoader' ) ) {
81 - $wgOut->addModules( 'ext.uploadWizard' );
82 - } else {
83 - $basepath = "$wgExtensionAssetsPath/UploadWizard";
84 - $dependencyLoader = new UploadWizardDependencyLoader( $wgLang->getCode() );
85 - if ( UploadWizardConfig::getSetting( 'debug', $this->campaign ) ) {
86 - // each file as an individual script or style
87 - $dependencyLoader->outputHtmlDebug( $wgOut, $basepath );
88 - } else {
89 - // combined & minified
90 - $dependencyLoader->outputHtml( $wgOut, $basepath );
91 - }
92 - }
 79+ $wgOut->addModules( 'ext.uploadWizard' );
9380
9481 // where the uploadwizard will go
9582 // TODO import more from UploadWizard's createInterface call.

Status & tagging log