r94827 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94826‎ | r94827 | r94828 >
Date:22:24, 17 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Based on diff to wikia, set more functions consistently public rather than protected
Modified paths:
  • /trunk/phase3/includes/api/ApiBlock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiComparePages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDisabled.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEmailUser.php (modified) (history)
  • /trunk/phase3/includes/api/ApiExpandTemplates.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFeedContributions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFeedWatchlist.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFileRevert.php (modified) (history)
  • /trunk/phase3/includes/api/ApiFormatBase.php (modified) (history)
  • /trunk/phase3/includes/api/ApiHelp.php (modified) (history)
  • /trunk/phase3/includes/api/ApiImport.php (modified) (history)
  • /trunk/phase3/includes/api/ApiLogin.php (modified) (history)
  • /trunk/phase3/includes/api/ApiLogout.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)
  • /trunk/phase3/includes/api/ApiOpenSearch.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPageSet.php (modified) (history)
  • /trunk/phase3/includes/api/ApiParamInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiParse.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPatrol.php (modified) (history)
  • /trunk/phase3/includes/api/ApiProtect.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPurge.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuery.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllCategories.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllimages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllmessages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryAllpages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBacklinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryBlocks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategories.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategoryInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryDisabled.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryDuplicateFiles.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExtLinksUsage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryExternalLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryFilearchive.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryIWBacklinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryIWLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImages.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLangBacklinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLangLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLinks.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryPageProps.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryProtectedTitles.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryQueryPage.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRandom.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryRevisions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySearch.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryStashImageInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryTags.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserContributions.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUsers.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryWatchlistRaw.php (modified) (history)
  • /trunk/phase3/includes/api/ApiRollback.php (modified) (history)
  • /trunk/phase3/includes/api/ApiRsd.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUnblock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUndelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUpload.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUserrights.php (modified) (history)
  • /trunk/phase3/includes/api/ApiWatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
@@ -633,7 +633,7 @@
634634 ) );
635635 }
636636
637 - protected function getExamples() {
 637+ public function getExamples() {
638638 return array(
639639 'api.php?action=query&list=recentchanges'
640640 );
Index: trunk/phase3/includes/api/ApiQueryAllLinks.php
@@ -221,7 +221,7 @@
222222 ) );
223223 }
224224
225 - protected function getExamples() {
 225+ public function getExamples() {
226226 return array(
227227 'api.php?action=query&list=alllinks&alunique=&alfrom=B',
228228 );
Index: trunk/phase3/includes/api/ApiQueryAllCategories.php
@@ -196,7 +196,7 @@
197197 return 'Enumerate all categories';
198198 }
199199
200 - protected function getExamples() {
 200+ public function getExamples() {
201201 return array(
202202 'api.php?action=query&list=allcategories&acprop=size',
203203 'api.php?action=query&generator=allcategories&gacprefix=List&prop=info',
Index: trunk/phase3/includes/api/ApiWatch.php
@@ -118,7 +118,7 @@
119119 ) );
120120 }
121121
122 - protected function getExamples() {
 122+ public function getExamples() {
123123 return array(
124124 'api.php?action=watch&title=Main_Page',
125125 'api.php?action=watch&title=Main_Page&unwatch=',
Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
@@ -633,7 +633,7 @@
634634 ) );
635635 }
636636
637 - protected function getExamples() {
 637+ public function getExamples() {
638638 return array(
639639 'api.php?action=query&meta=siteinfo&siprop=general|namespaces|namespacealiases|statistics',
640640 'api.php?action=query&meta=siteinfo&siprop=interwikimap&sifilteriw=local',
Index: trunk/phase3/includes/api/ApiQueryRandom.php
@@ -175,7 +175,7 @@
176176 );
177177 }
178178
179 - protected function getExamples() {
 179+ public function getExamples() {
180180 return 'api.php?action=query&list=random&rnnamespace=0&rnlimit=2';
181181 }
182182
Index: trunk/phase3/includes/api/ApiMove.php
@@ -254,7 +254,7 @@
255255 return '';
256256 }
257257
258 - protected function getExamples() {
 258+ public function getExamples() {
259259 return array(
260260 'api.php?action=move&from=Exampel&to=Example&token=123ABC&reason=Misspelled%20title&movetalk=&noredirect='
261261 );
Index: trunk/phase3/includes/api/ApiComparePages.php
@@ -118,7 +118,7 @@
119119 ) );
120120 }
121121
122 - protected function getExamples() {
 122+ public function getExamples() {
123123 return array(
124124 'api.php?action=compare&fromrev=1&torev=2',
125125 );
Index: trunk/phase3/includes/api/ApiQueryLinks.php
@@ -229,7 +229,7 @@
230230 return "Returns all {$this->description}s from the given page(s)";
231231 }
232232
233 - protected function getExamples() {
 233+ public function getExamples() {
234234 return array(
235235 "Get {$this->description}s from the [[Main Page]]:",
236236 " api.php?action=query&prop={$this->getModuleName()}&titles=Main%20Page",
Index: trunk/phase3/includes/api/ApiFileRevert.php
@@ -176,7 +176,7 @@
177177 return '';
178178 }
179179
180 - protected function getExamples() {
 180+ public function getExamples() {
181181 return array(
182182 'Revert Wiki.png to the version of 20110305152740:',
183183 ' api.php?action=filerevert&filename=Wiki.png&comment=Revert&archivename=20110305152740!Wiki.png&token=+\\',
Index: trunk/phase3/includes/api/ApiLogout.php
@@ -67,7 +67,7 @@
6868 return 'Log out and clear session data';
6969 }
7070
71 - protected function getExamples() {
 71+ public function getExamples() {
7272 return array(
7373 'api.php?action=logout'
7474 );
Index: trunk/phase3/includes/api/ApiParse.php
@@ -587,7 +587,7 @@
588588 ) );
589589 }
590590
591 - protected function getExamples() {
 591+ public function getExamples() {
592592 return array(
593593 'api.php?action=parse&text={{Project:Sandbox}}'
594594 );
Index: trunk/phase3/includes/api/ApiQueryExtLinksUsage.php
@@ -245,7 +245,7 @@
246246 ) );
247247 }
248248
249 - protected function getExamples() {
 249+ public function getExamples() {
250250 return array(
251251 'api.php?action=query&list=exturlusage&euquery=www.mediawiki.org'
252252 );
Index: trunk/phase3/includes/api/ApiQueryAllpages.php
@@ -312,7 +312,7 @@
313313 ) );
314314 }
315315
316 - protected function getExamples() {
 316+ public function getExamples() {
317317 return array(
318318 'Simple Use',
319319 ' Show a list of pages starting at the letter "B"',
Index: trunk/phase3/includes/api/ApiProtect.php
@@ -217,7 +217,7 @@
218218 return '';
219219 }
220220
221 - protected function getExamples() {
 221+ public function getExamples() {
222222 return array(
223223 'api.php?action=protect&title=Main%20Page&token=123ABC&protections=edit=sysop|move=sysop&cascade=&expiry=20070901163000|never',
224224 'api.php?action=protect&title=Main%20Page&token=123ABC&protections=edit=all|move=all&reason=Lifting%20restrictions'
Index: trunk/phase3/includes/api/ApiPurge.php
@@ -136,7 +136,7 @@
137137 ) );
138138 }
139139
140 - protected function getExamples() {
 140+ public function getExamples() {
141141 return array(
142142 'api.php?action=purge&titles=Main_Page|API'
143143 );
Index: trunk/phase3/includes/api/ApiQueryPageProps.php
@@ -142,7 +142,7 @@
143143 return 'Get various properties defined in the page content';
144144 }
145145
146 - protected function getExamples() {
 146+ public function getExamples() {
147147 return array(
148148 'api.php?action=query&prop=pageprops&titles=Category:Foo',
149149 );
Index: trunk/phase3/includes/api/ApiQueryBacklinks.php
@@ -511,7 +511,7 @@
512512 ) );
513513 }
514514
515 - protected function getExamples() {
 515+ public function getExamples() {
516516 static $examples = array(
517517 'backlinks' => array(
518518 'api.php?action=query&list=backlinks&bltitle=Main%20Page',
Index: trunk/phase3/includes/api/ApiRollback.php
@@ -184,7 +184,7 @@
185185 return $this->mTitleObj;
186186 }
187187
188 - protected function getExamples() {
 188+ public function getExamples() {
189189 return array(
190190 'api.php?action=rollback&title=Main%20Page&user=Catrope&token=123ABC',
191191 'api.php?action=rollback&title=Main%20Page&user=217.121.114.116&token=123ABC&summary=Reverting%20vandalism&markbot=1'
Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
@@ -385,7 +385,7 @@
386386 ) );
387387 }
388388
389 - protected function getExamples() {
 389+ public function getExamples() {
390390 return array(
391391 'List the last deleted revisions of Main Page and Talk:Main Page, with content (mode 1):',
392392 ' api.php?action=query&list=deletedrevs&titles=Main%20Page|Talk:Main%20Page&drprop=user|comment|content',
Index: trunk/phase3/includes/api/ApiExpandTemplates.php
@@ -118,7 +118,7 @@
119119 ) );
120120 }
121121
122 - protected function getExamples() {
 122+ public function getExamples() {
123123 return array(
124124 'api.php?action=expandtemplates&text={{Project:Sandbox}}'
125125 );
Index: trunk/phase3/includes/api/ApiUserrights.php
@@ -133,7 +133,7 @@
134134 return $this->getUser()->getName();
135135 }
136136
137 - protected function getExamples() {
 137+ public function getExamples() {
138138 return array(
139139 'api.php?action=userrights&user=FooBot&add=bot&remove=sysop|bureaucrat&token=123ABC'
140140 );
Index: trunk/phase3/includes/api/ApiDelete.php
@@ -269,7 +269,7 @@
270270 return '';
271271 }
272272
273 - protected function getExamples() {
 273+ public function getExamples() {
274274 return array(
275275 'api.php?action=delete&title=Main%20Page&token=123ABC',
276276 'api.php?action=delete&title=Main%20Page&token=123ABC&reason=Preparing%20for%20move'
Index: trunk/phase3/includes/api/ApiQueryBlocks.php
@@ -336,7 +336,7 @@
337337 ) );
338338 }
339339
340 - protected function getExamples() {
 340+ public function getExamples() {
341341 return array(
342342 'api.php?action=query&list=blocks',
343343 'api.php?action=query&list=blocks&bkusers=Alice|Bob'
Index: trunk/phase3/includes/api/ApiQueryFilearchive.php
@@ -285,7 +285,7 @@
286286 ) );
287287 }
288288
289 - protected function getExamples() {
 289+ public function getExamples() {
290290 return array(
291291 'Simple Use',
292292 ' Show a list of all deleted files',
Index: trunk/phase3/includes/api/ApiDisabled.php
@@ -65,7 +65,7 @@
6666 return 'This module has been disabled';
6767 }
6868
69 - protected function getExamples() {
 69+ public function getExamples() {
7070 return array();
7171 }
7272
Index: trunk/phase3/includes/api/ApiImport.php
@@ -158,7 +158,7 @@
159159 return '';
160160 }
161161
162 - protected function getExamples() {
 162+ public function getExamples() {
163163 return array(
164164 'Import [[meta:Help:Parserfunctions]] to namespace 100 with full history:',
165165 ' api.php?action=import&interwikisource=meta&interwikipage=Help:ParserFunctions&namespace=100&fullhistory=&token=123ABC',
Index: trunk/phase3/includes/api/ApiQueryCategoryMembers.php
@@ -379,7 +379,7 @@
380380 );
381381 }
382382
383 - protected function getExamples() {
 383+ public function getExamples() {
384384 return array(
385385 'Get first 10 pages in [[Category:Physics]]:',
386386 ' api.php?action=query&list=categorymembers&cmtitle=Category:Physics',
Index: trunk/phase3/includes/api/ApiQueryCategoryInfo.php
@@ -115,7 +115,7 @@
116116 return 'Returns information about the given categories';
117117 }
118118
119 - protected function getExamples() {
 119+ public function getExamples() {
120120 return 'api.php?action=query&prop=categoryinfo&titles=Category:Foo|Category:Bar';
121121 }
122122
Index: trunk/phase3/includes/api/ApiEditPage.php
@@ -415,7 +415,7 @@
416416 ) );
417417 }
418418
419 - protected function getAllowedParams() {
 419+ public function getAllowedParams() {
420420 return array(
421421 'title' => array(
422422 ApiBase::PARAM_TYPE => 'string',
@@ -468,7 +468,7 @@
469469 );
470470 }
471471
472 - protected function getParamDescription() {
 472+ public function getParamDescription() {
473473 $p = $this->getModulePrefix();
474474 return array(
475475 'title' => 'Page title',
@@ -513,7 +513,7 @@
514514 return '';
515515 }
516516
517 - protected function getExamples() {
 517+ public function getExamples() {
518518 return array(
519519 'Edit a page (anonymous user):',
520520 ' api.php?action=edit&title=Test&summary=test%20summary&text=article%20content&basetimestamp=20070824123454&token=%2B\\',
Index: trunk/phase3/includes/api/ApiFormatBase.php
@@ -288,7 +288,7 @@
289289 return $text;
290290 }
291291
292 - protected function getExamples() {
 292+ public function getExamples() {
293293 return 'api.php?action=query&meta=siteinfo&siprop=namespaces&format=' . $this->getModuleName();
294294 }
295295
Index: trunk/phase3/includes/api/ApiQueryAllimages.php
@@ -249,7 +249,7 @@
250250 ) );
251251 }
252252
253 - protected function getExamples() {
 253+ public function getExamples() {
254254 return array(
255255 'Simple Use',
256256 ' Show a list of images starting at the letter "B"',
Index: trunk/phase3/includes/api/ApiQueryAllmessages.php
@@ -246,7 +246,7 @@
247247 return 'Return messages from this site';
248248 }
249249
250 - protected function getExamples() {
 250+ public function getExamples() {
251251 return array(
252252 'api.php?action=query&meta=allmessages&amprefix=ipb-',
253253 'api.php?action=query&meta=allmessages&ammessages=august|mainpage&amlang=de',
Index: trunk/phase3/includes/api/ApiQuerySearch.php
@@ -295,7 +295,7 @@
296296 ) );
297297 }
298298
299 - protected function getExamples() {
 299+ public function getExamples() {
300300 return array(
301301 'api.php?action=query&list=search&srsearch=meaning',
302302 'api.php?action=query&list=search&srwhat=text&srsearch=meaning',
Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -445,7 +445,7 @@
446446 ) );
447447 }
448448
449 - protected function getExamples() {
 449+ public function getExamples() {
450450 return array(
451451 'api.php?action=query&list=logevents'
452452 );
Index: trunk/phase3/includes/api/ApiUnblock.php
@@ -141,7 +141,7 @@
142142 return '';
143143 }
144144
145 - protected function getExamples() {
 145+ public function getExamples() {
146146 return array(
147147 'api.php?action=unblock&id=105',
148148 'api.php?action=unblock&user=Bob&reason=Sorry%20Bob'
Index: trunk/phase3/includes/api/ApiQueryWatchlistRaw.php
@@ -197,7 +197,7 @@
198198 ) );
199199 }
200200
201 - protected function getExamples() {
 201+ public function getExamples() {
202202 return array(
203203 'api.php?action=query&list=watchlistraw',
204204 'api.php?action=query&generator=watchlistraw&gwrshow=changed&prop=revisions',
Index: trunk/phase3/includes/api/ApiQueryProtectedTitles.php
@@ -224,7 +224,7 @@
225225 return 'List all titles protected from creation';
226226 }
227227
228 - protected function getExamples() {
 228+ public function getExamples() {
229229 return array(
230230 'api.php?action=query&list=protectedtitles',
231231 );
Index: trunk/phase3/includes/api/ApiQuery.php
@@ -695,7 +695,7 @@
696696 ) );
697697 }
698698
699 - protected function getExamples() {
 699+ public function getExamples() {
700700 return array(
701701 'api.php?action=query&prop=revisions&meta=siteinfo&titles=Main%20Page&rvprop=user|comment',
702702 'api.php?action=query&generator=allpages&gapprefix=API/&prop=revisions',
Index: trunk/phase3/includes/api/ApiQueryIWLinks.php
@@ -166,7 +166,7 @@
167167 ) );
168168 }
169169
170 - protected function getExamples() {
 170+ public function getExamples() {
171171 return array(
172172 'Get interwiki links from the [[Main Page]]:',
173173 ' api.php?action=query&prop=iwlinks&titles=Main%20Page',
Index: trunk/phase3/includes/api/ApiLogin.php
@@ -206,7 +206,7 @@
207207 ) );
208208 }
209209
210 - protected function getExamples() {
 210+ public function getExamples() {
211211 return array(
212212 'api.php?action=login&lgname=user&lgpassword=password'
213213 );
Index: trunk/phase3/includes/api/ApiQueryLangLinks.php
@@ -159,7 +159,7 @@
160160 ) );
161161 }
162162
163 - protected function getExamples() {
 163+ public function getExamples() {
164164 return array(
165165 'Get interlanguage links from the [[Main Page]]:',
166166 ' api.php?action=query&prop=langlinks&titles=Main%20Page&redirects=',
Index: trunk/phase3/includes/api/ApiQueryUserInfo.php
@@ -231,7 +231,7 @@
232232 return 'Get information about the current user';
233233 }
234234
235 - protected function getExamples() {
 235+ public function getExamples() {
236236 return array(
237237 'api.php?action=query&meta=userinfo',
238238 'api.php?action=query&meta=userinfo&uiprop=blockinfo|groups|rights|hasmsg',
Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -568,7 +568,7 @@
569569 ) );
570570 }
571571
572 - protected function getExamples() {
 572+ public function getExamples() {
573573 return array(
574574 'api.php?action=query&titles=File:Albert%20Einstein%20Head.jpg&prop=imageinfo',
575575 'api.php?action=query&titles=File:Test.jpg&prop=imageinfo&iilimit=50&iiend=20071231235959&iiprop=timestamp|user|url',
Index: trunk/phase3/includes/api/ApiEmailUser.php
@@ -138,7 +138,7 @@
139139 return '';
140140 }
141141
142 - protected function getExamples() {
 142+ public function getExamples() {
143143 return array(
144144 'api.php?action=emailuser&target=WikiSysop&text=Content'
145145 );
Index: trunk/phase3/includes/api/ApiFeedContributions.php
@@ -195,7 +195,7 @@
196196 ) );
197197 }
198198
199 - protected function getExamples() {
 199+ public function getExamples() {
200200 return array(
201201 'api.php?action=feedcontributions&user=Reedy',
202202 );
Index: trunk/phase3/includes/api/ApiQueryStashImageInfo.php
@@ -127,7 +127,7 @@
128128 return 'Returns image information for stashed images';
129129 }
130130
131 - protected function getExamples() {
 131+ public function getExamples() {
132132 return array(
133133 'api.php?action=query&prop=stashimageinfo&siifilekey=124sd34rsdf567',
134134 'api.php?action=query&prop=stashimageinfo&siifilekey=b34edoe3|bceffd4&siiurlwidth=120&siiprop=url',
Index: trunk/phase3/includes/api/ApiOpenSearch.php
@@ -119,7 +119,7 @@
120120 return 'Search the wiki using the OpenSearch protocol';
121121 }
122122
123 - protected function getExamples() {
 123+ public function getExamples() {
124124 return array(
125125 'api.php?action=opensearch&search=Te'
126126 );
Index: trunk/phase3/includes/api/ApiQueryIWBacklinks.php
@@ -207,7 +207,7 @@
208208 ) );
209209 }
210210
211 - protected function getExamples() {
 211+ public function getExamples() {
212212 return array(
213213 'api.php?action=query&list=iwbacklinks&iwbltitle=Test&iwblprefix=wikibooks',
214214 'api.php?action=query&generator=iwbacklinks&giwbltitle=Test&iwblprefix=wikibooks&prop=info'
Index: trunk/phase3/includes/api/ApiQueryQueryPage.php
@@ -97,7 +97,7 @@
9898 }
9999 }
100100 $result->addValue( array( 'query' ), $this->getModuleName(), $r );
101 -
 101+
102102 if ( $qp->isCached() && !$qp->isCacheable() ) {
103103 // Disabled query page, don't run the query
104104 return;
@@ -186,7 +186,7 @@
187187 ) );
188188 }
189189
190 - protected function getExamples() {
 190+ public function getExamples() {
191191 return array(
192192 'api.php?action=query&list=querypage&qppage=Ancientpages'
193193 );
Index: trunk/phase3/includes/api/ApiPageSet.php
@@ -464,7 +464,7 @@
465465 __METHOD__ );
466466 $this->profileDBOut();
467467 }
468 -
 468+
469469 $this->initFromQueryResult( $res, $remaining, false ); // process PageIDs
470470
471471 // Resolve any found redirects
@@ -743,7 +743,7 @@
744744 return $array;
745745 }
746746
747 - protected function getAllowedParams() {
 747+ public function getAllowedParams() {
748748 return array(
749749 'titles' => array(
750750 ApiBase::PARAM_ISMULTI => true
@@ -759,7 +759,7 @@
760760 );
761761 }
762762
763 - protected function getParamDescription() {
 763+ public function getParamDescription() {
764764 return array(
765765 'titles' => 'A list of titles to work on',
766766 'pageids' => 'A list of page IDs to work on',
Index: trunk/phase3/includes/api/ApiHelp.php
@@ -139,7 +139,7 @@
140140 return 'Display this help screen. Or the help screen for the specified module';
141141 }
142142
143 - protected function getExamples() {
 143+ public function getExamples() {
144144 return array(
145145 'Whole help page:',
146146 ' api.php?action=help',
Index: trunk/phase3/includes/api/ApiQueryWatchlist.php
@@ -439,7 +439,7 @@
440440 ) );
441441 }
442442
443 - protected function getExamples() {
 443+ public function getExamples() {
444444 return array(
445445 'api.php?action=query&list=watchlist',
446446 'api.php?action=query&list=watchlist&wlprop=ids|title|timestamp|user|comment',
Index: trunk/phase3/includes/api/ApiRsd.php
@@ -71,7 +71,7 @@
7272 return 'Export an RSD (Really Simple Discovery) schema';
7373 }
7474
75 - protected function getExamples() {
 75+ public function getExamples() {
7676 return array(
7777 'api.php?action=rsd'
7878 );
Index: trunk/phase3/includes/api/ApiQueryLangBacklinks.php
@@ -207,7 +207,7 @@
208208 ) );
209209 }
210210
211 - protected function getExamples() {
 211+ public function getExamples() {
212212 return array(
213213 'api.php?action=query&list=langbacklinks&lbltitle=Test&lbllang=fr',
214214 'api.php?action=query&generator=langbacklinks&glbltitle=Test&lbllang=fr&prop=info'
Index: trunk/phase3/includes/api/ApiBlock.php
@@ -208,7 +208,7 @@
209209 return '';
210210 }
211211
212 - protected function getExamples() {
 212+ public function getExamples() {
213213 return array(
214214 'api.php?action=block&user=123.5.5.12&expiry=3%20days&reason=First%20strike',
215215 'api.php?action=block&user=Vandal&expiry=never&reason=Vandalism&nocreate=&autoblock=&noemail='
Index: trunk/phase3/includes/api/ApiQueryDisabled.php
@@ -63,7 +63,7 @@
6464 );
6565 }
6666
67 - protected function getExamples() {
 67+ public function getExamples() {
6868 return array();
6969 }
7070
Index: trunk/phase3/includes/api/ApiPatrol.php
@@ -104,7 +104,7 @@
105105 return 'patrol';
106106 }
107107
108 - protected function getExamples() {
 108+ public function getExamples() {
109109 return array(
110110 'api.php?action=patrol&token=123abc&rcid=230672766'
111111 );
Index: trunk/phase3/includes/api/ApiUndelete.php
@@ -152,7 +152,7 @@
153153 return '';
154154 }
155155
156 - protected function getExamples() {
 156+ public function getExamples() {
157157 return array(
158158 'api.php?action=undelete&title=Main%20Page&token=123ABC&reason=Restoring%20main%20page',
159159 'api.php?action=undelete&title=Main%20Page&token=123ABC&timestamps=20070703220045|20070702194856'
Index: trunk/phase3/includes/api/ApiQueryRevisions.php
@@ -651,7 +651,7 @@
652652 ) );
653653 }
654654
655 - protected function getExamples() {
 655+ public function getExamples() {
656656 return array(
657657 'Get data with content for the last revision of titles "API" and "Main Page":',
658658 ' api.php?action=query&prop=revisions&titles=API|Main%20Page&rvprop=timestamp|user|comment|content',
Index: trunk/phase3/includes/api/ApiQueryExternalLinks.php
@@ -143,7 +143,7 @@
144144 ) );
145145 }
146146
147 - protected function getExamples() {
 147+ public function getExamples() {
148148 return array(
149149 'Get a list of external links on the [[Main Page]]:',
150150 ' api.php?action=query&prop=extlinks&titles=Main%20Page',
Index: trunk/phase3/includes/api/ApiQueryCategories.php
@@ -241,7 +241,7 @@
242242 ) );
243243 }
244244
245 - protected function getExamples() {
 245+ public function getExamples() {
246246 return array(
247247 'Get a list of categories [[Albert Einstein]] belongs to:',
248248 ' api.php?action=query&prop=categories&titles=Albert%20Einstein',
Index: trunk/phase3/includes/api/ApiParamInfo.php
@@ -244,7 +244,7 @@
245245 return 'Obtain information about certain API parameters and errors';
246246 }
247247
248 - protected function getExamples() {
 248+ public function getExamples() {
249249 return array(
250250 'api.php?action=paraminfo&modules=parse&querymodules=allpages|siteinfo'
251251 );
Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
@@ -355,7 +355,7 @@
356356 ) );
357357 }
358358
359 - protected function getExamples() {
 359+ public function getExamples() {
360360 return array(
361361 'api.php?action=query&list=allusers&aufrom=Y',
362362 );
Index: trunk/phase3/includes/api/ApiQueryInfo.php
@@ -721,7 +721,7 @@
722722 ) );
723723 }
724724
725 - protected function getExamples() {
 725+ public function getExamples() {
726726 return array(
727727 'api.php?action=query&prop=info&titles=Main%20Page',
728728 'api.php?action=query&prop=info&inprop=protection&titles=Main%20Page'
Index: trunk/phase3/includes/api/ApiQueryDuplicateFiles.php
@@ -161,7 +161,7 @@
162162 ) );
163163 }
164164
165 - protected function getExamples() {
 165+ public function getExamples() {
166166 return array(
167167 'api.php?action=query&titles=File:Albert_Einstein_Head.jpg&prop=duplicatefiles',
168168 'api.php?action=query&generator=allimages&prop=duplicatefiles',
Index: trunk/phase3/includes/api/ApiQueryTags.php
@@ -178,7 +178,7 @@
179179 return 'List change tags';
180180 }
181181
182 - protected function getExamples() {
 182+ public function getExamples() {
183183 return array(
184184 'api.php?action=query&list=tags&tgprop=displayname|description|hitcount'
185185 );
Index: trunk/phase3/includes/api/ApiUpload.php
@@ -605,7 +605,7 @@
606606 return '';
607607 }
608608
609 - protected function getExamples() {
 609+ public function getExamples() {
610610 return array(
611611 'Upload from a URL:',
612612 ' api.php?action=upload&filename=Wiki.png&url=http%3A//upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png',
Index: trunk/phase3/includes/api/ApiFeedWatchlist.php
@@ -214,7 +214,7 @@
215215 ) );
216216 }
217217
218 - protected function getExamples() {
 218+ public function getExamples() {
219219 return array(
220220 'api.php?action=feedwatchlist',
221221 'api.php?action=feedwatchlist&allrev=&linktodiffs=&hours=6'
Index: trunk/phase3/includes/api/ApiQueryUserContributions.php
@@ -463,7 +463,7 @@
464464 ) );
465465 }
466466
467 - protected function getExamples() {
 467+ public function getExamples() {
468468 return array(
469469 'api.php?action=query&list=usercontribs&ucuser=YurikBot',
470470 'api.php?action=query&list=usercontribs&ucuserprefix=217.121.114.',
Index: trunk/phase3/includes/api/ApiQueryUsers.php
@@ -318,7 +318,7 @@
319319 return 'Get information about a list of users';
320320 }
321321
322 - protected function getExamples() {
 322+ public function getExamples() {
323323 return 'api.php?action=query&list=users&ususers=brion|TimStarling&usprop=groups|editcount|gender';
324324 }
325325
Index: trunk/phase3/includes/api/ApiQueryImages.php
@@ -176,7 +176,7 @@
177177 ) );
178178 }
179179
180 - protected function getExamples() {
 180+ public function getExamples() {
181181 return array(
182182 'Get a list of images used in the [[Main Page]]:',
183183 ' api.php?action=query&prop=images&titles=Main%20Page',

Status & tagging log