r94813 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94812‎ | r94813 | r94814 >
Date:21:24, 17 August 2011
Author:nad
Status:deferred
Tags:
Comment:
record forms in edit view need their attributes preserved
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin.php (modified) (history)
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)
  • /trunk/extensions/RecordAdmin/recordadmin.js (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/recordadmin.js
@@ -1,7 +1,7 @@
22 window.raRecordForms = function () {
33 for( i = 0; i < window.forms.length; i++ ) {
44 var type = forms[i];
5 - var form = document.getElementById( type + '-form' );
 5+ var form = document.getElementById( type.toLowerCase() + '-form' );
66 var tags = [ 'input', 'select', 'textarea' ];
77 for( j = 0; j < tags.length; j++ ) {
88 var inputs = form.getElementsByTagName( tags[j] );
@@ -21,5 +21,4 @@
2222 }
2323 }
2424 };
25 -
2625 jQuery( '#editform' ).attr( 'onsubmit', 'raRecordForms()' );
Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -96,7 +96,7 @@
9797 $values = $this->valuesFromText( $record );
9898 $this->populateForm( $values );
9999 $tabset .= "<fieldset><legend>$type " . strtolower( wfMsg( 'recordadmin-properties' ) ) . "</legend>\n";
100 - $tabset .= "<form id=\"$type-form\" class=\"$type-record recordadmin\">$this->form</form>\n";
 100+ $tabset .= "<form id=\"$type-form\" class=\"{$this->formClass}\"{$this->formAtts}>$this->form</form>\n";
101101 $tabset .= "</fieldset>";
102102 }
103103
Index: trunk/extensions/RecordAdmin/RecordAdmin.php
@@ -10,7 +10,7 @@
1111 * @author Siebrand Mazeland
1212 * @licence GNU General Public Licence 2.0 or later
1313 */
14 -define( 'RECORDADMIN_VERSION', '1.3.0, 2011-08-03' );
 14+define( 'RECORDADMIN_VERSION', '1.3.1, 2011-08-18' );
1515
1616 $wgRecordAdminExtPath = preg_replace( "|^.*(/extensions/.*$)|", "$wgScriptPath$1", dirname( __FILE__ ) );
1717

Status & tagging log