r94798 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94797‎ | r94798 | r94799 >
Date:19:24, 17 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove unused globals and other variables

Fix whitespace
Modified paths:
  • /trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleFeedback/SpecialArticleFeedback.php
@@ -15,7 +15,7 @@
1616 }
1717
1818 public function execute( $par ) {
19 - global $wgUser, $wgOut, $wgRequest, $wgLang, $wgArticleFeedbackDashboard, $wgArticleFeedbackDashboardTalkPage;
 19+ global $wgOut, $wgLang, $wgArticleFeedbackDashboard, $wgArticleFeedbackDashboardTalkPage;
2020
2121 $wgOut->addModules( 'ext.articleFeedback.dashboard' );
2222 $this->setHeaders();
@@ -111,7 +111,7 @@
112112 * @return String: HTML table of daily highs and lows
113113 */
114114 protected function renderDailyHighsAndLows( $pages, $caption ) {
115 - global $wgOut, $wgUser;
 115+ global $wgUser;
116116
117117 // Pre-fill page ID cache
118118 $ids = array();
@@ -129,7 +129,7 @@
130130 continue;
131131 }
132132 $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
133 - foreach ( $page['ratings'] as $id => $value ) {
 133+ foreach ( $page['ratings'] as $value ) {
134134 $row[] = array(
135135 'text' => $this->formatNumber( $value ),
136136 'attr' => array(
@@ -167,7 +167,7 @@
168168 * @return String: HTML table of weekly most changed
169169 */
170170 protected function renderWeeklyMostChanged() {
171 - global $wgOut, $wgUser;
 171+ global $wgUser;
172172
173173 $rows = array();
174174 foreach ( $this->getWeeklyMostChanged() as $page ) {
@@ -201,9 +201,8 @@
202202 * @return String: HTML table of recent lows
203203 */
204204 protected function renderProblems() {
205 - global $wgOut, $wgUser, $wgArticleFeedbackRatings;
 205+ global $wgUser;
206206
207 -
208207 $problems = $this->getProblems();
209208
210209 // Pre-fill page ID cache
@@ -221,7 +220,7 @@
222221 continue;
223222 }
224223 $row['page'] = $wgUser->getSkin()->link( $pageTitle, $pageTitle->getPrefixedText() );
225 - foreach ( $page['ratings'] as $id => $value ) {
 224+ foreach ( $page['ratings'] as $value ) {
226225 $row[] = array(
227226 'text' => $this->formatNumber( $value ),
228227 'attr' => array(

Status & tagging log