r94774 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94773‎ | r94774 | r94775 >
Date:16:47, 17 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
bug regarding concepts (originally noted in r92056)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -391,6 +391,7 @@
392392 }
393393
394394 if ( !isset( $this->m_params[$desckey] ) ) {
 395+ // / @bug The current SMWStore will never return SMWConceptValue (an SMWDataValue) here; it might return SMWDIConcept (an SMWDataItem)
395396 $dv = end( smwfGetStore()->getPropertyValues( SMWWikiPageValue::makePageFromTitle( $concept ), new SMWDIProperty( '_CONC' ) ) );
396397 if ( $dv instanceof SMWConceptValue ) {
397398 $this->m_params[$desckey] = $dv->getDocu();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92056reviewed code, smaller improvements in style and logic, some comments/todos f...mkroetzsch11:32, 13 July 2011