r94755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94754‎ | r94755 | r94756 >
Date:13:41, 17 August 2011
Author:catrope
Status:resolved
Tags:
Comment:
1.17wmf1: MFT r94754
Modified paths:
  • /branches/wmf/1.17wmf1/includes/RecentChange.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.17wmf1/includes/RecentChange.php
@@ -644,7 +644,9 @@
645645 // XXX: *HACK^2* the preg_replace() undoes much of what getInternalURL() does, but we
646646 // XXX: need to call it so that URL paths on the Wikimedia secure server can be fixed
647647 // XXX: by a custom GetInternalURL hook --vyznev 2008-12-10
648 - $url = preg_replace( '/title=[^&]*&/', '', $titleObj->getInternalURL( $url ) );
 648+ // XXX: Also, getInternalUrl() may return a protocol-relative URL.
 649+ // XXX: In that case, expand it to an HTTP URL, even if this is an HTTPS request --catrope 2011-08-17
 650+ $url = preg_replace( '/title=[^&]*&/', '', wfExpandUrl( $titleObj->getInternalURL( $url ), PROTO_HTTP ) );
649651 }
650652
651653 if( isset( $oldSize ) && isset( $newSize ) ) {
Property changes on: branches/wmf/1.17wmf1/includes/RecentChange.php
___________________________________________________________________
Added: svn:mergeinfo
652654 Merged /branches/REL1_15/phase3/includes/RecentChange.php:r51646
653655 Merged /branches/wmf/1.16wmf4/includes/RecentChange.php:r67177,69199,76243,77266
654656 Merged /branches/sqlite/includes/RecentChange.php:r58211-58321
655657 Merged /trunk/phase3/includes/RecentChange.php:r83590,89512-89513,94754
656658 Merged /branches/new-installer/phase3/includes/RecentChange.php:r43664-66004
657659 Merged /branches/wmf-deployment/includes/RecentChange.php:r53381,60970

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94754(bug 30398) Expand any protocol-relative URLs to HTTP in RecentChange::getIRC...catrope13:32, 17 August 2011

Status & tagging log