| Index: branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php |
| — | — | @@ -1241,10 +1241,11 @@ |
| 1242 | 1242 | * @param string $commentId |
| 1243 | 1243 | * @return \type |
| 1244 | 1244 | */ |
| 1245 | | - public function getFullUrl( $commentId = '' ) { |
| | 1245 | + public function getFullUrl( $commentId = 0 ) { |
| 1246 | 1246 | $title = SpecialPage::getTitleFor( 'Code', $this->repo->getName() . '/' . $this->id ); |
| 1247 | 1247 | |
| 1248 | | - if ( $commentId !== '' ) { |
| | 1248 | + # Append comment id if not null, empty string or zero |
| | 1249 | + if ( $commentId ) { |
| 1249 | 1250 | $title->setFragment( "#c{$commentId}" ); |
| 1250 | 1251 | } |
| 1251 | 1252 | |
| Property changes on: branches/wmf/1.17wmf1/extensions/CodeReview/backend/CodeRevision.php |
| ___________________________________________________________________ |
| Added: svn:mergeinfo |
| 1252 | 1253 | Merged /branches/REL1_15/phase3/extensions/CodeReview/backend/CodeRevision.php:r51646 |
| 1253 | 1254 | Merged /branches/wmf/1.16wmf4/extensions/CodeReview/backend/CodeRevision.php:r67177,69199,76243,77266 |
| 1254 | 1255 | Merged /trunk/extensions/CodeReview/backend/CodeRevision.php:r77974-93070,94506 |
| 1255 | 1256 | Merged /backend/CodeRevision.php:r91549 |
| 1256 | 1257 | Merged /branches/sqlite/extensions/CodeReview/backend/CodeRevision.php:r58211-58321 |
| 1257 | 1258 | Merged /trunk/phase3/extensions/CodeReview/backend/CodeRevision.php:r79828,79830,79848,79853,79950-79951,79954,79989,80006-80007,80013,80016,80080,80083,80124,80128,80238,81833,83212,83590 |
| 1258 | 1259 | Merged /branches/new-installer/phase3/extensions/CodeReview/backend/CodeRevision.php:r43664-66004 |
| 1259 | 1260 | Merged /branches/wmf-deployment/extensions/CodeReview/backend/CodeRevision.php:r60970 |