r94617 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94616‎ | r94617 | r94618 >
Date:10:47, 16 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
minor cleanup
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php
@@ -341,7 +341,6 @@
342342 *
343343 * @global OutputPage $wgOut
344344 * @global string $smwgScriptPath
345 - * @param string $errors
346345 * @return string
347346 */
348347 protected function getQueryFormBox() {
@@ -405,7 +404,7 @@
406405 if ( !$smwgQSortingSupport ) return array();
407406
408407 $params = array();
409 - //loading all values from form
 408+ // loading all values from form
410409 $orderValues = $wgRequest->getArray( 'order' );
411410 $propertyValues = $wgRequest->getArray( 'property' );
412411 $propertyLabelValues = $wgRequest->getArray( 'prop_label' );
@@ -680,7 +679,7 @@
681680 $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i", 'class' => 'smwsort' ) );
682681 $result .= '<span class="smwquisortlabel"><span class="smw-remove"><a href="javascript:removePOInstance(\'sort_div_' . $i . '\')"><img src="' . $smwgScriptPath . '/skins/images/close-button.png" alt="' . wfMsg( 'smw_qui_delete' ) . '"></a></span>';
683682 $result .= wfMsg( 'smw_qui_property' ) . '</span>';
684 - $result .= Html::input( 'property[' . $i . ']', $propertyValues[$key], 'text', array( 'size' => '35', 'id' => "property$i" ) ) . "\n";
 683+ $result .= Html::input( 'property[' . $i . ']', $propertyValues[$key], 'text', array( 'size' => '25', 'id' => "property$i" ) ) . "\n";
685684 $result .= Html::openElement( 'select', array( 'name' => "order[$i]" ) );
686685
687686 $if1 = ( !is_array( $orderValues ) || !array_key_exists( $key, $orderValues ) || $orderValues[$key] == 'NONE' );
@@ -1127,7 +1126,7 @@
11281127
11291128 foreach ( $orders as $i => $order ) {
11301129 $result .= "<div id=\"sort_div_$i\">" . wfMsg( 'smw_ask_sortby' ) . ' <input type="text" name="sort[' . $i . ']" value="' .
1131 - htmlspecialchars( $sorts[$i] ) . "\" size=\"35\"/>\n" . '<select name="order[' . $i . ']"><option ';
 1130+ htmlspecialchars( $sorts[$i] ) . "\" size=\"25\"/>\n" . '<select name="order[' . $i . ']"><option ';
11321131 if ( $order == 'ASC' ) $result .= 'selected="selected" ';
11331132 $result .= 'value="ASC">' . wfMsg( 'smw_qui_ascorder' ) . '</option><option ';
11341133 if ( $order == 'DESC' ) $result .= 'selected="selected" ';
@@ -1137,7 +1136,7 @@
11381137 $result .= "</div>\n";
11391138 }
11401139
1141 - $hidden .= '<div id="sorting_starter" style="display: none">' . wfMsg( 'smw_ask_sortby' ) . ' <input type="text" size="35" />' . "\n";
 1140+ $hidden .= '<div id="sorting_starter" style="display: none">' . wfMsg( 'smw_ask_sortby' ) . ' <input type="text" size="25" />' . "\n";
11421141 $hidden .= ' <select name="order_num">' . "\n";
11431142 $hidden .= ' <option value="ASC">' . wfMsg( 'smw_qui_ascorder' ) . "</option>\n";
11441143 $hidden .= ' <option value="DESC">' . wfMsg( 'smw_qui_descorder' ) . "</option>\n</select>\n";
@@ -1571,7 +1570,7 @@
15721571 *
15731572 * Required by getFormatSelectBox() to recieve form elements from the Web.
15741573 * UIs may need to overload processFormatOptions(),
1575 - * getgetFormatSelectBox() and getFormatSelectBox() to change behavior.
 1574+ * processFormatSelectBox() and getFormatSelectBox() to change behavior.
15761575 *
15771576 * @param WebRequest $wgRequest
15781577 * @return boolean true if format options were requested and returned, else false