r94559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94558‎ | r94559 | r94560 >
Date:20:27, 15 August 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
0.3 rel
Modified paths:
  • /trunk/extensions/SemanticSignup/INSTALL (modified) (history)
  • /trunk/extensions/SemanticSignup/SemanticSignup.php (modified) (history)
  • /trunk/extensions/SemanticSignup/SemanticSignup.settings.php (modified) (history)
  • /trunk/extensions/SemanticSignup/release-notes (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticSignup/SemanticSignup.php
@@ -41,7 +41,7 @@
4242 die( '<b>Error:</b> You need to have <a href="http://semantic-mediawiki.org/wiki/Semantic_Forms">Semantic Forms</a> installed in order to use SemanticSignup.' );
4343 }
4444
45 -define( 'SemanticSignup_VERSION', '0.3 alpha' );
 45+define( 'SemanticSignup_VERSION', '0.3' );
4646
4747 $wgExtensionCredits[defined( 'SEMANTIC_EXTENSION_TYPE' ) ? 'semantic' : 'specialpage'][] = array(
4848 'path' => __FILE__,
Index: trunk/extensions/SemanticSignup/INSTALL
@@ -37,9 +37,32 @@
3838
3939 == Configuration ==
4040
41 -Configuration of SemanticSignup is done by adding simple PHP statements to your
 41+Configuration of SemanticSignup is done by assigning to $egSemanticSignupSettings in your
4242 [[Manual:LocalSettings.php|LocalSettings.php]] file. These statements need to be placed
4343 AFTER the inclusion of SemanticSignup. The options are listed below and their default
4444 is set in the [http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticSignup/SemanticSignup.settings.php?view=markup SemanticSignup settings file].
4545 You should NOT modify the settings file, but can have a look at it to get an idea of
4646 how to use the settings, in case the below descriptions do not suffice.
 47+
 48+=== Require name ===
 49+
 50+Require entering a real name during the registration process?
 51+
 52+Default: $egSemanticSignupSettings['requireName'] = false; // true or false
 53+
 54+=== Form name ===
 55+
 56+The name of the form you want to use for signup.
 57+
 58+Default: $egSemanticSignupSettings['formName'] = '';
 59+
 60+Example: $egSemanticSignupSettings['formName'] = 'Signup_form';
 61+
 62+=== Bot name ===
 63+
 64+The name of the user to create the user page with. This user needs
 65+sufficient priviliges to create new pages in the User: namespace.
 66+
 67+Default: $egSemanticSignupSettings['botName'] = '';
 68+
 69+Example: $egSemanticSignupSettings['botName'] = 'Admin';
Index: trunk/extensions/SemanticSignup/release-notes
@@ -5,14 +5,16 @@
66
77
88 === Version 0.3 ===
9 -2011-0x-xx
 9+2011-08-15
1010
1111 * Added compatibility with MediaWiki 1.16 and above, removed compatibility with MediaWiki below 1.16.
1212 * Added compatibility with Semantic MediaWiki 1.6 and above.
1313 * Added INSTALL file.
14 -* Rewrote setting handling.
 14+* Added checks for dependencies (MW, SMW, & SF)
 15+* Rewrote setting handling, breaking compatibility with older versions.
1516 * Moved entry point to SemanticSignup.php.
1617 * Moved code to standard i18n, hooks and settings files.
 18+* Split DataChecker classes code to separate files.
1719 * Stylized code.
1820
1921 === Version 0.2 ===
Index: trunk/extensions/SemanticSignup/SemanticSignup.settings.php
@@ -4,9 +4,8 @@
55 * File defining the settings for the SemanticSignup extension.
66 * More info can be found at http://www.mediawiki.org/wiki/Extension:SemanticSignup#Settings
77 *
8 - * NOTICE:
9 - * Changing one of these settings can be done by copying or cutting it,
10 - * and placing it in LocalSettings.php, AFTER the inclusion of this extension.
 8+ * NOTICE:
 9+ * Changing one of these settings can be done by assigning to $egSemanticSignupSettings.
1110 *
1211 * @file SemanticSignup.settings.php
1312 * @ingroup SemanticSignup
@@ -14,7 +13,6 @@
1514 * @licence GNU GPL v3+
1615 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
1716 */
18 -
1917 class SemanticSignupSettings {
2018
2119 protected static function getDefaultSettings() {