r94544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94543‎ | r94544 | r94545 >
Date:18:41, 15 August 2011
Author:inez
Status:deferred
Tags:
Comment:
Put empty implementation of getText method in ListBlock to just avoid throwing errors
Modified paths:
  • /trunk/parsers/wikidom/lib/es/es.ListBlock.js (modified) (history)

Diff [purge]

Index: trunk/parsers/wikidom/lib/es/es.ListBlock.js
@@ -98,7 +98,7 @@
9999
100100 this.list.traverseItems( function( item, index ) {
101101 itemLength = item.content.getLength();
102 - if ( offset >= globalOffset && offset < globalOffset + itemLength ) {
 102+ if ( offset >= globalOffset && offset <= globalOffset + itemLength ) {
103103 position = item.flow.getPosition( offset - globalOffset );
104104 contentOffset = item.$content.offset();
105105 position.top += contentOffset.top - blockOffset.top;
@@ -113,6 +113,10 @@
114114 return position;
115115 };
116116
 117+es.ListBlock.prototype.getText = function( range, render ) {
 118+ return "";
 119+};
 120+
117121 /* Registration */
118122
119123 /**

Status & tagging log