r94475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94474‎ | r94475 | r94476 >
Date:19:50, 14 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix fail from r94473

Append to the string, don't replace it
Modified paths:
  • /trunk/phase3/includes/Xml.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Xml.php
@@ -794,7 +794,7 @@
795795 $s = Xml::openElement( 'table', $attribs );
796796
797797 if ( is_array( $headers ) ) {
798 - $s = Xml::openElement( 'thead', $attribs );
 798+ $s .= Xml::openElement( 'thead', $attribs );
799799
800800 foreach( $headers as $id => $header ) {
801801 $attribs = array();
@@ -805,7 +805,7 @@
806806
807807 $s .= Xml::element( 'th', $attribs, $header );
808808 }
809 - $s = Xml::closeElement( 'thead' );
 809+ $s .= Xml::closeElement( 'thead' );
810810 }
811811
812812 foreach( $rows as $id => $row ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94473Made Xml::buildTable() wrap header stuff in <thead></thead>reedy19:47, 14 August 2011

Status & tagging log