r94438 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94437‎ | r94438 | r94439 >
Date:00:47, 14 August 2011
Author:jeroendedauw
Status:deferred
Tags:lamecommitsummary 
Comment:
Modified paths:
  • /trunk/extensions/Maps/includes/Maps_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/Maps_Settings.php
@@ -315,7 +315,7 @@
316316 /**
317317 * Simple class to define settings, which can be represented
318318 * as key values pairs, together with meta data such as
319 - * description messages and how they can berepresented in
 319+ * description messages and how they can be represented in
320320 * as UI elements.
321321 *
322322 * @since ?
@@ -325,9 +325,9 @@
326326 */
327327 class Setting {
328328
329 - public $name;
330 - public $value;
331 - public $message = false;
 329+ protected $name;
 330+ protected $value;
 331+ protected $message = false;
332332
333333 public static function newFromValue( $name, $value ) {
334334 return new Setting( $name, $value );
@@ -347,4 +347,12 @@
348348 return $this->name;
349349 }
350350
 351+ public function getMessage() {
 352+ return $this->message;
 353+ }
 354+
 355+ public function setMessage( $message ) {
 356+ $this->message = $message;
 357+ }
 358+
351359 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r944311.0.1 RCjeroendedauw21:13, 13 August 2011

Status & tagging log